http: do not default to chunked encoding for TRACE

Fixes: #25783 PR-URL: #27673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 20, 2019 · bfb9356 · bfb9356
1 parent 83f2430
commit bfb9356
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -180,6 +180,7 @@ function ClientRequest(input, options, cb) {
       method === 'HEAD' ||
       method === 'DELETE' ||
       method === 'OPTIONS' ||
+      method === 'TRACE' ||
       method === 'CONNECT') {
     this.useChunkedEncodingByDefault = false;
   } else {

diff --git a/test/parallel/test-http-client-default-headers-exist.js b/test/parallel/test-http-client-default-headers-exist.js
@@ -31,7 +31,8 @@ const expectedHeaders = {
   'HEAD': ['host', 'connection'],
   'OPTIONS': ['host', 'connection'],
   'POST': ['host', 'connection', 'content-length'],
-  'PUT': ['host', 'connection', 'content-length']
+  'PUT': ['host', 'connection', 'content-length'],
+  'TRACE': ['host', 'connection']
 };
 
 const expectedMethods = Object.keys(expectedHeaders);