Skip to content

Commit

Permalink
test_runner: switched to internal readline interface
Browse files Browse the repository at this point in the history
Switched to using internal interface after

PR-URL: #54000
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
Emiltayeb authored and marco-ippolito committed Aug 19, 2024
1 parent 61b90e7 commit c0262c1
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/internal/test_runner/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ const { spawn } = require('child_process');
const { readdirSync, statSync } = require('fs');
const { finished } = require('internal/streams/end-of-stream');
const { DefaultDeserializer, DefaultSerializer } = require('v8');
// TODO(aduh95): switch to internal/readline/interface when backporting to Node.js 16.x is no longer a concern.
const { createInterface } = require('readline');
const { Interface } = require('internal/readline/interface');
const { deserializeError } = require('internal/error_serdes');
const { Buffer } = require('buffer');
const { FilesWatcher } = require('internal/watch_mode/files_watcher');
Expand Down Expand Up @@ -394,7 +393,7 @@ function runTestFile(path, filesWatcher, opts) {
subtest.parseMessage(data);
});

const rl = createInterface({ __proto__: null, input: child.stderr });
const rl = new Interface({ __proto__: null, input: child.stderr });
rl.on('line', (line) => {
if (isInspectorMessage(line)) {
process.stderr.write(line + '\n');
Expand Down

0 comments on commit c0262c1

Please sign in to comment.