fs: mkdtemp shouldn't crash if no callback passed

As it is, `fs.mkdtemp` crashes with a C++ assertion if the callback function is not passed. This patch uses `maybeCallback` to create one, if no callback function is passed. PR-URL: #6828 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jun 2, 2016 · c068880 · c068880
1 parent 5afb91b
commit c068880
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -1994,7 +1994,8 @@ SyncWriteStream.prototype.destroy = function() {
 
 SyncWriteStream.prototype.destroySoon = SyncWriteStream.prototype.destroy;
 
-fs.mkdtemp = function(prefix, options, callback) {
+fs.mkdtemp = function(prefix, options, callback_) {
+  var callback = maybeCallback(callback_);
   if (!prefix || typeof prefix !== 'string')
     throw new TypeError('filename prefix is required');
 

diff --git a/test/parallel/test-fs-mkdtemp.js b/test/parallel/test-fs-mkdtemp.js
@@ -25,3 +25,5 @@ fs.mkdtemp(
       assert(common.fileExists(folder));
     })
 );
+
+assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-')));
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,3 +25,5 @@ fs.mkdtemp( @@
           assert(common.fileExists(folder));
         })
     );
+    assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-')));