Skip to content

Commit

Permalink
util: fix inspecting error with a throwing getter for cause
Browse files Browse the repository at this point in the history
PR-URL: #47163
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
aduh95 authored and RafaelGSS committed Apr 8, 2023
1 parent 2192b5b commit cbb3627
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 2 deletions.
11 changes: 9 additions & 2 deletions lib/internal/util/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -1243,9 +1243,16 @@ function getStackString(error) {
function getStackFrames(ctx, err, stack) {
const frames = StringPrototypeSplit(stack, '\n');

let cause;
try {
({ cause } = err);
} catch {
// If 'cause' is a getter that throws, ignore it.
}

// Remove stack frames identical to frames in cause.
if (err.cause && isError(err.cause)) {
const causeStack = getStackString(err.cause);
if (cause != null && isError(cause)) {
const causeStack = getStackString(cause);
const causeStackStart = StringPrototypeIndexOf(causeStack, '\n at');
if (causeStackStart !== -1) {
const causeFrames = StringPrototypeSplit(StringPrototypeSlice(causeStack, causeStackStart + 1), '\n');
Expand Down
6 changes: 6 additions & 0 deletions test/message/util-inspect-error-cause.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,9 @@ process.nextTick(() => {
console.log(inspect(cause3));
console.log(inspect(error2));
});

{
const error = new Error('cause that throws');
Reflect.defineProperty(error, 'cause', { get() { throw new Error(); } });
console.log(inspect(error));
}
10 changes: 10 additions & 0 deletions test/message/util-inspect-error-cause.out
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ Error: undefined cause
at * {
[cause]: undefined
}
Error: cause that throws
at *
at *
at *
at *
at *
at *
at * {
[cause]: [Getter]
}
RangeError: New Stack Frames
at *
*[90m at *[39m {
Expand Down

0 comments on commit cbb3627

Please sign in to comment.