test: remove common.enoughTestCpu

All hosts in CI return true for common.enoughTestCpu. At least for our CI, it is always true, so we can remove it. PR-URL: #39161 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Jul 11, 2021 · cdc7a19 · cdc7a19
1 parent bd472da
commit cdc7a19
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 33 deletions.
diff --git a/test/common/README.md b/test/common/README.md
@@ -62,13 +62,6 @@ On non-Windows platforms, this always returns `true`.
 
 Creates a 10 MB file of all null characters.
 
-### `enoughTestCpu`
-
-* [&lt;boolean>][]
-
-Indicates if there is more than 1 CPU or that the single CPU has a speed of at
-least 1 GHz.
-
 ### `enoughTestMem`
 
 * [&lt;boolean>][]

diff --git a/test/common/index.js b/test/common/index.js
@@ -788,11 +788,6 @@ const common = {
   skipIfInspectorDisabled,
   skipIfWorker,
 
-  get enoughTestCpu() {
-    const cpus = require('os').cpus();
-    return Array.isArray(cpus) && (cpus.length > 1 || cpus[0].speed > 999);
-  },
-
   get enoughTestMem() {
     return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
   },

diff --git a/test/common/index.mjs b/test/common/index.mjs
@@ -18,7 +18,6 @@ const {
   isLinux,
   isOSX,
   enoughTestMem,
-  enoughTestCpu,
   buildType,
   localIPv6Hosts,
   opensslCli,
@@ -64,7 +63,6 @@ export {
   isLinux,
   isOSX,
   enoughTestMem,
-  enoughTestCpu,
   buildType,
   localIPv6Hosts,
   opensslCli,

diff --git a/test/pummel/test-fs-watch-system-limit.js b/test/pummel/test-fs-watch-system-limit.js
@@ -9,10 +9,6 @@ if (!common.isLinux) {
   common.skip('The fs watch limit is OS-dependent');
 }
 
-if (!common.enoughTestCpu) {
-  common.skip('This test is resource-intensive');
-}
-
 if ((process.config.variables.arm_version === '6') ||
   (process.config.variables.arm_version === '7')) {
   common.skip('Too slow for armv6 and armv7 bots');

diff --git a/test/tick-processor/test-tick-processor-builtin.js b/test/tick-processor/test-tick-processor-builtin.js
@@ -2,9 +2,6 @@
 const common = require('../common');
 const { isCPPSymbolsNotMapped } = require('./util');
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
-
 if (isCPPSymbolsNotMapped) {
   common.skip('C++ symbols are not mapped for this os.');
 }

diff --git a/test/tick-processor/test-tick-processor-cpp-core.js b/test/tick-processor/test-tick-processor-cpp-core.js
@@ -2,9 +2,6 @@
 const common = require('../common');
 const { isCPPSymbolsNotMapped } = require('./util');
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
-
 if (isCPPSymbolsNotMapped) {
   common.skip('C++ symbols are not mapped for this os.');
 }

diff --git a/test/tick-processor/test-tick-processor-polyfill-brokenfile.js b/test/tick-processor/test-tick-processor-polyfill-brokenfile.js
@@ -4,9 +4,6 @@ const { isCPPSymbolsNotMapped } = require('./util');
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
-
 if (isCPPSymbolsNotMapped) {
   common.skip('C++ symbols are not mapped for this OS.');
 }

diff --git a/test/tick-processor/test-tick-processor-preprocess-flag.js b/test/tick-processor/test-tick-processor-preprocess-flag.js
@@ -2,9 +2,6 @@
 const common = require('../common');
 const { isCPPSymbolsNotMapped } = require('./util');
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
-
 if (isCPPSymbolsNotMapped) {
   common.skip('C++ symbols are not mapped for this os.');
 }

diff --git a/test/tick-processor/test-tick-processor-unknown.js b/test/tick-processor/test-tick-processor-unknown.js
@@ -9,9 +9,6 @@ const common = require('../common');
 if (common.isAIX)
   common.skip('AIX address range too big for scripts.');
 
-if (!common.enoughTestCpu)
-  common.skip('test is CPU-intensive');
-
 const base = require('./tick-processor-base.js');
 
 // Unknown checked for to prevent flakiness, if pattern is not found,