From cfdcd6cf33b1fcf81db7f034fba7fdfd94d248b4 Mon Sep 17 00:00:00 2001 From: kozyatinskiy Date: Mon, 27 Mar 2017 12:26:18 -0700 Subject: [PATCH] v8: backport 43791ce02c8 from upstream v8 Original commit message: [PATCH] [inspector] finally removed *ExecuteScript from inspector We don't need hints from embedder any more. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158} PR-URL: https://github.com/nodejs/node/pull/13217 Reviewed-By: Franziska Hinkelmann Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- deps/v8/include/v8-inspector.h | 2 -- deps/v8/src/inspector/v8-inspector-impl.cc | 15 --------------- deps/v8/src/inspector/v8-inspector-impl.h | 2 -- 3 files changed, 19 deletions(-) diff --git a/deps/v8/include/v8-inspector.h b/deps/v8/include/v8-inspector.h index c7209ed69aeae7..43bf3b4f60b1c8 100644 --- a/deps/v8/include/v8-inspector.h +++ b/deps/v8/include/v8-inspector.h @@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector { virtual void resetContextGroup(int contextGroupId) = 0; // Various instrumentation. - virtual void willExecuteScript(v8::Local, int scriptId) = 0; - virtual void didExecuteScript(v8::Local) = 0; virtual void idleStarted() = 0; virtual void idleFinished() = 0; diff --git a/deps/v8/src/inspector/v8-inspector-impl.cc b/deps/v8/src/inspector/v8-inspector-impl.cc index 34e41208acd7cb..cacd9d54722057 100644 --- a/deps/v8/src/inspector/v8-inspector-impl.cc +++ b/deps/v8/src/inspector/v8-inspector-impl.cc @@ -285,21 +285,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) { m_debugger->wasmTranslation()->Clear(); } -void V8InspectorImpl::willExecuteScript(v8::Local context, - int scriptId) { - if (V8DebuggerAgentImpl* agent = - enabledDebuggerAgentForGroup(contextGroupId(context))) { - agent->willExecuteScript(scriptId); - } -} - -void V8InspectorImpl::didExecuteScript(v8::Local context) { - if (V8DebuggerAgentImpl* agent = - enabledDebuggerAgentForGroup(contextGroupId(context))) { - agent->didExecuteScript(); - } -} - void V8InspectorImpl::idleStarted() { for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) { if (it->second->profilerAgent()->idleStarted()) return; diff --git a/deps/v8/src/inspector/v8-inspector-impl.h b/deps/v8/src/inspector/v8-inspector-impl.h index 9d6e62c908804e..4c5e4fa979ca96 100644 --- a/deps/v8/src/inspector/v8-inspector-impl.h +++ b/deps/v8/src/inspector/v8-inspector-impl.h @@ -85,8 +85,6 @@ class V8InspectorImpl : public V8Inspector { void contextCreated(const V8ContextInfo&) override; void contextDestroyed(v8::Local) override; void resetContextGroup(int contextGroupId) override; - void willExecuteScript(v8::Local, int scriptId) override; - void didExecuteScript(v8::Local) override; void idleStarted() override; void idleFinished() override; unsigned exceptionThrown(v8::Local, const StringView& message,