From d1fcdc24c4d3dc0575c2d0150584fe4189c3dbf9 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sat, 6 Oct 2018 10:39:18 -0400 Subject: [PATCH] doc,meta: assign PR semantics MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/23292 Refs: https://github.com/nodejs/node/pull/23249 Reviewed-By: Michaël Zasso Reviewed-By: Vse Mozhet Byt Reviewed-By: Anna Henningsen Reviewed-By: Trivikram Kamat Reviewed-By: Rich Trott --- COLLABORATOR_GUIDE.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 8d260be70f2d18..7dba23dc74e566 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -100,7 +100,8 @@ As soon as the PR is ready to land, please do so. Landing your own pull requests allows other Collaborators to focus on other pull requests. If your pull request is still awaiting the [minimum time to land](#waiting-for-approvals), add the `author ready` label so other Collaborators know it can land as soon as the time -ends. +ends. If instead you wish to land the PR yourself, indicate this intent by using +the "assign yourself" button, to self-assign the PR. ## Accepting Modifications @@ -501,6 +502,9 @@ The TSC should serve as the final arbiter where required. ## Landing Pull Requests +1. Avoid landing PRs that are assigned to someone else. Authors who wish to land + their own PRs will self-assign them, or delegate to someone else. If in + doubt, ask the assignee whether it is okay to land. 1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not using the web interface button: * The "Create a merge commit" method will add an unnecessary merge commit.