From d3a70e9cd4548ddc9f13f691eb40cdccc8295d35 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 3 Mar 2018 22:02:55 -0800 Subject: [PATCH] doc: remove tentativeness in pull-requests.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Anatoli Papirovski Reviewed-By: Tobias Nießen Reviewed-By: Gibson Fahnestock Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- doc/guides/contributing/pull-requests.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 4fd2de923a0e48..7ac8389e313349 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -401,10 +401,10 @@ seem unfamiliar, refer to this All Pull Requests require "sign off" in order to land. Whenever a contributor reviews a Pull Request they may find specific details that they would like to see changed or fixed. These may be as simple as fixing a typo, or may involve -substantive changes to the code you have written. In general, such requests -are intended to be helpful, but at times may come across as abrupt or unhelpful, -especially requests to change things that do not include concrete suggestions -on *how* to change them. +substantive changes to the code you have written. While such requests are +intended to be helpful, they may come across as abrupt or unhelpful, especially +requests to change things that do not include concrete suggestions on *how* to +change them. Try not to be discouraged. If you feel that a particular review is unfair, say so, or contact one of the other contributors in the project and seek their @@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page. For the size of "one logical change", [0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8) can be a good example. It touches the implementation, the documentation, -and the tests, but is still one logical change. In general, the tests should -always pass when each individual commit lands on the master branch. +and the tests, but is still one logical change. All tests should always pass +when each individual commit lands on the master branch. ### Getting Approvals for Your Pull Request