Skip to content

Commit

Permalink
test: remove unnecessary common.platformTimeout() call
Browse files Browse the repository at this point in the history
Applying platformTimeout() to the interval is counterproductive. It
should be applied to the request timeout duration only.

PR-URL: #30677
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott authored and MylesBorins committed Dec 17, 2019

Unverified

The email in this signature doesn’t match the committer email.
1 parent 564e477 commit d3bac60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/sequential/test-http-server-consumed-timeout.js
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ function runTest(timeoutDuration) {
const interval = setInterval(() => {
intervalWasInvoked = true;
req.write('a');
}, common.platformTimeout(25));
}, 25);
setTimeout(() => {
clearInterval(interval);
req.end();

0 comments on commit d3bac60

Please sign in to comment.