From d7ae79a452ca31b63946149eeb03f99fa7a351c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Reis?= Date: Wed, 23 Sep 2015 13:33:09 +0100 Subject: [PATCH] build,win: fix node.exe resource version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: https://github.com/nodejs/node/issues/2963 PR-URL: https://github.com/nodejs/node/pull/3053 Reviewed-By: Alexis Campailla Reviewed-By: Johan Bergström --- src/res/node.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/res/node.rc b/src/res/node.rc index 0bdb2a0dc74f90..bc2c58a185e061 100644 --- a/src/res/node.rc +++ b/src/res/node.rc @@ -53,8 +53,8 @@ BEGIN VALUE "CompanyName", "Joyent, Inc" VALUE "ProductName", "Node.js" VALUE "FileDescription", "Evented I/O for V8 JavaScript" - VALUE "FileVersion", NODE_VERSION_STRING - VALUE "ProductVersion", NODE_VERSION_STRING + VALUE "FileVersion", NODE_EXE_VERSION + VALUE "ProductVersion", NODE_EXE_VERSION VALUE "OriginalFilename", "node.exe" VALUE "InternalName", "node" VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."