From d81c67bd8f72aced704eb64aedeb79e074238fa8 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 2 Jun 2019 22:02:44 -0400 Subject: [PATCH] src: fix unused private field warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/28036 Reviewed-By: Daniel Bevenius Reviewed-By: Michaƫl Zasso Reviewed-By: Yongsheng Zhang Reviewed-By: Sam Roberts Reviewed-By: Ruben Bridgewater --- src/inspector/runtime_agent.cc | 4 ++-- src/inspector/runtime_agent.h | 3 +-- src/inspector_agent.cc | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/inspector/runtime_agent.cc b/src/inspector/runtime_agent.cc index 4056140e703493..037a77dbb9d044 100644 --- a/src/inspector/runtime_agent.cc +++ b/src/inspector/runtime_agent.cc @@ -7,8 +7,8 @@ namespace node { namespace inspector { namespace protocol { -RuntimeAgent::RuntimeAgent(Environment* env) - : notify_when_waiting_for_disconnect_(false), env_(env) {} +RuntimeAgent::RuntimeAgent() + : notify_when_waiting_for_disconnect_(false) {} void RuntimeAgent::Wire(UberDispatcher* dispatcher) { frontend_ = std::make_unique(dispatcher->channel()); diff --git a/src/inspector/runtime_agent.h b/src/inspector/runtime_agent.h index 63fc2a897caf21..4c249f8e82f625 100644 --- a/src/inspector/runtime_agent.h +++ b/src/inspector/runtime_agent.h @@ -12,7 +12,7 @@ namespace protocol { class RuntimeAgent : public NodeRuntime::Backend { public: - explicit RuntimeAgent(Environment* env); + RuntimeAgent(); void Wire(UberDispatcher* dispatcher); @@ -23,7 +23,6 @@ class RuntimeAgent : public NodeRuntime::Backend { private: std::shared_ptr frontend_; bool notify_when_waiting_for_disconnect_; - Environment* env_; }; } // namespace protocol } // namespace inspector diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index c19f4d9f8f4eab..2e51648196672f 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel, tracing_agent_->Wire(node_dispatcher_.get()); worker_agent_ = std::make_unique(worker_manager); worker_agent_->Wire(node_dispatcher_.get()); - runtime_agent_ = std::make_unique(env); + runtime_agent_ = std::make_unique(); runtime_agent_->Wire(node_dispatcher_.get()); }