From df25424b9195d3122452989582a6988d1ea342a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 5 Aug 2021 16:30:32 +0200 Subject: [PATCH] build: fix V8 build with pointer compression Refs: https://github.com/nodejs/TSC/issues/790#issuecomment-893457655 PR-URL: https://github.com/nodejs/node/pull/39664 Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Mary Marchini --- common.gypi | 5 ++++- tools/v8_gypfiles/features.gypi | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 88764c8f6b75a8..4e1f4fb24e454b 100644 --- a/common.gypi +++ b/common.gypi @@ -356,7 +356,10 @@ ], }], ['v8_enable_pointer_compression == 1', { - 'defines': ['V8_COMPRESS_POINTERS'], + 'defines': [ + 'V8_COMPRESS_POINTERS', + 'V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE', + ], }], ['v8_enable_pointer_compression == 1 or v8_enable_31bit_smis_on_64bit_arch == 1', { 'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH'], diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index 68da6ef3378904..6bb08bcebeca91 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -261,7 +261,10 @@ 'defines': ['ENABLE_MINOR_MC',], }], ['v8_enable_pointer_compression==1', { - 'defines': ['V8_COMPRESS_POINTERS',], + 'defines': [ + 'V8_COMPRESS_POINTERS', + 'V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE', + ], }], ['v8_enable_pointer_compression==1 or v8_enable_31bit_smis_on_64bit_arch==1', { 'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH',],