From e2df381da9ff257f7e4bc68030c23f14bdd87ae2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 21 Dec 2021 19:49:56 -0800 Subject: [PATCH] tools: add double-quotes to make-v8.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: https://github.com/nodejs/node/pull/41257 Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- tools/make-v8.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/make-v8.sh b/tools/make-v8.sh index c63cb9ccf77301..978b9f00860a65 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -17,7 +17,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then fi # set paths manually for now to use locally installed gn export BUILD_TOOLS=/home/iojs/build-tools - export LD_LIBRARY_PATH=$BUILD_TOOLS:$LD_LIBRARY_PATH + export LD_LIBRARY_PATH="$BUILD_TOOLS:$LD_LIBRARY_PATH" # Avoid linking to ccache symbolic links as ccache decides which # binary to run based on the name of the link (we always name them gcc/g++). # shellcheck disable=SC2154 @@ -28,7 +28,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then rm -f "$BUILD_TOOLS/gcc" ln -s "$CXX_PATH" "$BUILD_TOOLS/g++" ln -s "$CC_PATH" "$BUILD_TOOLS/gcc" - export PATH=$BUILD_TOOLS:$PATH + export PATH="$BUILD_TOOLS:$PATH" g++ --version gcc --version