From ec0d623bd7917945eef72b8e6ffc0727bb07979e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Date: Fri, 18 Feb 2022 16:46:32 +0100
Subject: [PATCH] lib: add FormData global when fetch is enabled

PR-URL: https://github.com/nodejs/node/pull/41956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 .eslintrc.js                            |  1 +
 doc/api/globals.md                      | 11 +++++++++++
 lib/.eslintrc.yaml                      |  2 ++
 lib/internal/bootstrap/pre_execution.js |  6 ++++++
 test/common/index.js                    |  1 +
 test/parallel/test-fetch.mjs            |  1 +
 test/wpt/test-url.js                    |  2 +-
 tools/doc/type-parser.mjs               |  1 +
 8 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 83b855bbb5b159..720a2786aa9f62 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -319,6 +319,7 @@ module.exports = {
     Crypto: 'readable',
     CryptoKey: 'readable',
     fetch: 'readable',
+    FormData: 'readable',
     globalThis: 'readable',
     Response: 'readable',
     SubtleCrypto: 'readable',
diff --git a/doc/api/globals.md b/doc/api/globals.md
index 7ca4251d6e46b8..bfc1a2dae32726 100644
--- a/doc/api/globals.md
+++ b/doc/api/globals.md
@@ -363,6 +363,17 @@ added: v17.5.0
 
 A browser-compatible implementation of the [`fetch()`][] function.
 
+## Class `FormData`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental. Enable this API with the [`--experimental-fetch`][]
+> CLI flag.
+
+A browser-compatible implementation of {FormData}.
+
 ## `global`
 
 <!-- YAML
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
index b148c56495c505..f0a3307ea22faf 100644
--- a/lib/.eslintrc.yaml
+++ b/lib/.eslintrc.yaml
@@ -47,6 +47,8 @@ rules:
       message: Use `const { Event } = require('internal/event_target');` instead of the global.
     - name: EventTarget
       message: Use `const { EventTarget } = require('internal/event_target');` instead of the global.
+    - name: FormData
+      message: Use `const { FormData } = require('internal/deps/undici/undici');` instead of the global.
     - name: Headers
       message: Use `const { Headers } = require('internal/deps/undici/undici');` instead of the global.
       # Intl is not available in primordials because it can be
diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
index f6187c9446480a..be5d0c832b6092 100644
--- a/lib/internal/bootstrap/pre_execution.js
+++ b/lib/internal/bootstrap/pre_execution.js
@@ -163,6 +163,12 @@ function setupFetch() {
     configurable: true,
     value: undici.fetch
   });
+  ObjectDefineProperty(globalThis, 'FormData', {
+    writable: true,
+    enumerable: false,
+    configurable: true,
+    value: undici.FormData
+  });
   ObjectDefineProperty(globalThis, 'Headers', {
     writable: true,
     enumerable: false,
diff --git a/test/common/index.js b/test/common/index.js
index 46a59b54d52459..d550d6b8fd76bd 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -303,6 +303,7 @@ if (global.structuredClone) {
 if (global.fetch) {
   knownGlobals.push(
     global.fetch,
+    global.FormData,
     global.Request,
     global.Response,
     global.Headers,
diff --git a/test/parallel/test-fetch.mjs b/test/parallel/test-fetch.mjs
index fa433c78fc78ef..d435ec3fa6e2b5 100644
--- a/test/parallel/test-fetch.mjs
+++ b/test/parallel/test-fetch.mjs
@@ -7,6 +7,7 @@ import events from 'events';
 import http from 'http';
 
 assert.strictEqual(typeof globalThis.fetch, 'function');
+assert.strictEqual(typeof globalThis.FormData, 'function');
 assert.strictEqual(typeof globalThis.Headers, 'function');
 assert.strictEqual(typeof globalThis.Request, 'function');
 assert.strictEqual(typeof globalThis.Response, 'function');
diff --git a/test/wpt/test-url.js b/test/wpt/test-url.js
index f381c439fbeffd..419c48715feab0 100644
--- a/test/wpt/test-url.js
+++ b/test/wpt/test-url.js
@@ -11,7 +11,7 @@ runner.setScriptModifier((obj) => {
     // created via `document.createElement`. So we need to ignore them and just
     // test `URL`.
     obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
-  } else if (typeof FormData === 'undefined' && // eslint-disable-line
+  } else if (typeof FormData === 'undefined' &&
       obj.filename.includes('urlsearchparams-constructor.any.js')) {
     // TODO(XadillaX): Remove this `else if` after `FormData` is supported.
 
diff --git a/tools/doc/type-parser.mjs b/tools/doc/type-parser.mjs
index 1f49fefa7e1c14..e17bf077d70f3c 100644
--- a/tools/doc/type-parser.mjs
+++ b/tools/doc/type-parser.mjs
@@ -271,6 +271,7 @@ const customTypesMap = {
   'TextDecoderStream':
     'webstreams.md#class-textdecoderstream',
 
+  'FormData': 'https://developer.mozilla.org/en-US/docs/Web/API/FormData',
   'Headers': 'https://developer.mozilla.org/en-US/docs/Web/API/Headers',
   'Response': 'https://developer.mozilla.org/en-US/docs/Web/API/Response',
   'Request': 'https://developer.mozilla.org/en-US/docs/Web/API/Request',