From ed465eb595452b9fd0e9696de5d1a6f7790b9985 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 6 Mar 2019 13:44:11 -0800 Subject: [PATCH] doc: edit "Involving the TSC" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: https://github.com/nodejs/node/pull/26481 Reviewed-By: Richard Lau Reviewed-By: Yuta Hiroto Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Beth Griggs Reviewed-By: Colin Ihrig --- COLLABORATOR_GUIDE.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 608dd347e5f55a..a14aaaa04988fc 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -374,13 +374,12 @@ deprecation level of an API. ### Involving the TSC Collaborators may opt to elevate pull requests or issues to the [TSC][]. -This should be done where a pull request: +Do this if a pull request or issue: - is labeled `semver-major`, or - has a significant impact on the codebase, or -- is inherently controversial, or -- has failed to reach consensus amongst the Collaborators who are - actively participating in the discussion. +- is controversial, or +- is at an impasse among Collaborators who are participating in the discussion. Assign the `tsc-review` label or @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].