From efde4b75129a0600611fa5cdd8e49c4d72f0ac90 Mon Sep 17 00:00:00 2001 From: NiveditN Date: Tue, 28 Nov 2017 15:43:10 +0530 Subject: [PATCH] test: expanded assertions for console.timeEnd() output Added assertions to verify that console.time() coerces labels to strings correctly, by comparing against the expected output values of console.timeEnd(). This helps resolve https://github.com/nodejs/node/issues/14544 but will not address the whole thing. PR-URL: https://github.com/nodejs/node/pull/17368 Refs: https://github.com/nodejs/node/pull/14643 Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Sakthipriyan Vairamani --- test/parallel/test-console.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/parallel/test-console.js b/test/parallel/test-console.js index eadb3a32a19ebf..618caf6f25252f 100644 --- a/test/parallel/test-console.js +++ b/test/parallel/test-console.js @@ -176,6 +176,14 @@ assert.ok(/^__proto__: \d+\.\d{3}ms$/.test(strings.shift().trim())); assert.ok(/^constructor: \d+\.\d{3}ms$/.test(strings.shift().trim())); assert.ok(/^hasOwnProperty: \d+\.\d{3}ms$/.test(strings.shift().trim())); +// verify that console.time() coerces label values to strings as expected +assert.ok(/^: \d+\.\d{3}ms$/.test(strings.shift().trim())); +assert.ok(/^\[object Object\]: \d+\.\d{3}ms$/.test(strings.shift().trim())); +assert.ok(/^null: \d+\.\d{3}ms$/.test(strings.shift().trim())); +assert.ok(/^default: \d+\.\d{3}ms$/.test(strings.shift().trim())); +assert.ok(/^default: \d+\.\d{3}ms$/.test(strings.shift().trim())); +assert.ok(/^NaN: \d+\.\d{3}ms$/.test(strings.shift().trim())); + assert.strictEqual(errStrings.shift().split('\n').shift(), 'Trace: This is a {"formatted":"trace"} 10 foo');