From f3518f333703e804ff024dc04a56f3cdd532f3d9 Mon Sep 17 00:00:00 2001 From: Deokjin Kim Date: Sun, 1 Jan 2023 20:07:47 +0900 Subject: [PATCH] test: use `process.hrtime.bigint` instead of `process.hrtime` `process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel --- test/parallel/test-http2-session-timeout.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/parallel/test-http2-session-timeout.js b/test/parallel/test-http2-session-timeout.js index 0fa6a2c13c6b6c..c1dacdcb455e28 100644 --- a/test/parallel/test-http2-session-timeout.js +++ b/test/parallel/test-http2-session-timeout.js @@ -5,6 +5,8 @@ if (!common.hasCrypto) common.skip('missing crypto'); const assert = require('assert'); const http2 = require('http2'); +const hrtime = process.hrtime.bigint; +const NS_PER_MS = 1_000_000n; let requests = 0; const mustNotCall = () => { @@ -14,7 +16,7 @@ const mustNotCall = () => { const server = http2.createServer(); // Disable server timeout until first request. We will set the timeout based on // how long the first request takes. -server.timeout = 0; +server.timeout = 0n; server.on('request', (req, res) => res.end()); server.on('timeout', mustNotCall); @@ -24,7 +26,7 @@ server.listen(0, common.mustCall(() => { const url = `http://localhost:${port}`; const client = http2.connect(url); - let startTime = process.hrtime(); + let startTime = hrtime(); makeReq(); function makeReq() { @@ -40,17 +42,17 @@ server.listen(0, common.mustCall(() => { requests += 1; request.on('end', () => { - const diff = process.hrtime(startTime); - const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6); - if (server.timeout === 0) { + const diff = hrtime() - startTime; + const milliseconds = diff / NS_PER_MS; + if (server.timeout === 0n) { // Set the timeout now. First connection will take significantly longer // than subsequent connections, so using the duration of the first // connection as the timeout should be robust. Double it anyway for good // measure. - server.timeout = milliseconds * 2; - startTime = process.hrtime(); + server.timeout = milliseconds * 2n; + startTime = hrtime(); makeReq(); - } else if (milliseconds < server.timeout * 2) { + } else if (milliseconds < server.timeout * 2n) { makeReq(); } else { server.removeListener('timeout', mustNotCall);