Skip to content

Commit

Permalink
test: add test for dns.promises.resolve .
Browse files Browse the repository at this point in the history
PR-URL: #21691
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
kakts authored and targos committed Jul 12, 2018
1 parent 577d24b commit f386c0a
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions test/parallel/test-dns-promises-resolve.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
'use strict';
const common = require('../common');
const assert = require('assert');

const dnsPromises = require('dns').promises;

common.crashOnUnhandledRejection();

// Error when rrtype is invalid.
{
const rrtype = 'DUMMY';
common.expectsError(
() => dnsPromises.resolve('example.org', rrtype),
{
code: 'ERR_INVALID_OPT_VALUE',
type: TypeError,
message: `The value "${rrtype}" is invalid for option "rrtype"`
}
);
}

// Error when rrtype is a number.
{
const rrtype = 0;
common.expectsError(
() => dnsPromises.resolve('example.org', rrtype),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "rrtype" argument must be of type string. ' +
`Received type ${typeof rrtype}`
}
);
}

// rrtype is undefined, it's same as resolve4
{
(async function() {
const rrtype = undefined;
const result = await dnsPromises.resolve('example.org', rrtype);
assert.ok(result !== undefined);
assert.ok(result.length > 0);
})();
}

0 comments on commit f386c0a

Please sign in to comment.