Skip to content

Commit

Permalink
test: reorder asserts arguments
Browse files Browse the repository at this point in the history
Revert arguments for assert and ensure that the first
argument is always the actual value being tested.

PR-URL: #23534
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
frony authored and jasnell committed Oct 17, 2018
1 parent 26fa85c commit ffab8ba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/pummel/test-net-pause.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ server.on('listening', function() {
setTimeout(function() {
chars_recved = recv.length;
console.log(`pause at: ${chars_recved}`);
assert.strictEqual(true, chars_recved > 1);
assert.strictEqual(chars_recved > 1, true);
client.pause();
setTimeout(function() {
console.log(`resume at: ${chars_recved}`);
Expand Down Expand Up @@ -86,6 +86,6 @@ server.on('listening', function() {
server.listen(common.PORT);

process.on('exit', function() {
assert.strictEqual(N, recv.length);
assert.strictEqual(recv.length, N);
console.error('Exit');
});

0 comments on commit ffab8ba

Please sign in to comment.