Don't kill node.js / REPL

[pannous]

Version: v7.5.0
Platform: Darwin iMac.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64

Somehow a broken promise kills the whole REPL:

> /usr/local/lib/node_modules/selenium-webdriver/lib/promise.js:2517
        throw error;
        ^

InvalidArgumentError: Missing required parameter: sessionId
    at buildPath (/usr/local/lib/node_modules/selenium-webdriver/lib/http.js:552:15)
    at toHttpRequest (/usr/local/lib/node_modules/selenium-webdriver/lib/http.js:367:16)
    at Executor.execute (/usr/local/lib/node_modules/selenium-webdriver/lib/http.js:433:19)
    at process._tickDomainCallback (internal/process/next_tick.js:129:7)
From: Task: WebDriver.findElement(By(css selector, *[name="login"]))
    at WebDriver.findElement (/usr/local/lib/node_modules/selenium-webdriver/lib/webdriver.js:1023:17)
    at repl:1:5
    at sigintHandlersWrap (vm.js:98:12)
    at REPLServer.defaultEval (repl.js:307:29)
    at bound (domain.js:280:14)
    at REPLServer.onLine (repl.js:506:10)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:188:7)
    at REPLServer.Interface._onLine (readline.js:247:10)
    at REPLServer.Interface._line (readline.js:591:8)
From: Task: WebElement.sendKeys()
    at repl:1:42
    at sigintHandlersWrap (vm.js:98:12)
    at REPLServer.defaultEval (repl.js:307:29)
    at bound (domain.js:280:14)
    at REPLServer.onLine (repl.js:506:10)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:188:7)
    at REPLServer.Interface._onLine (readline.js:247:10)
    at REPLServer.Interface._line (readline.js:591:8)
    at REPLServer.Interface._ttyWrite (readline.js:870:14)
home:~/

This must never occur!

[bnoordhuis]

Easy way to reproduce? Is this with the built-in promises implementation or a custom one?

[pannous]

Oh, I assumed it had to do with the previous node.js warning similar to "soon every promise not handled will result in a bluescreen" Let me check... You mean it could be a hidden SEGFAULT?

[pannous]

require('child_process').exec("chromedriver")
const driver = require('selenium-webdriver')
let doc = new driver.Builder() .usingServer('http://localhost:9515') .withCapabilities({chromeOptions: {binary: '/usr/local/bin/Electron'} }) .forBrowser('electron') .build()
doc.get("http://xyz.com")
doc.findElement(driver.By.name('abc'))

forgive my ignorance: is there a kind of error which makes the REPL quit by design?

[bnoordhuis]

When I said 'easy', I was hoping for something that doesn't involve all of selenium... Can you reproduce with just a bare REPL, no third-party dependencies?

[pannous]

I was hoping it had to do with this warning:

> new Promise(function (fulfill, reject){throw 0})
Promise { <rejected> 0 }
> (node:22916) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): 0
(node:22916) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

looks like this is a separate issue.

however since the warning indicates a horrible plan to make node.js terminate ever so often, is there any (other) place to petition against this planned behavior?

[bnoordhuis]

See #8217 and the issues linked therein. Can this issue be closed then?

[pannous]

thx