Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that rely upon common.spawnCat() faill in Windows with Unicode shell codepage #11470

Closed
vsemozhetbyt opened this issue Feb 20, 2017 · 3 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 20, 2017

  • Version: possibly all
  • Platform: Windows 7 x64
  • Subsystem: test, child_process

For context see #11469

test/parallel/test-child-process-stdio-inherit.js calls common.spawnCat() that calls more for Windows. more fails with Unicode shell codepage.

To check test/parallel/test-child-process-stdio-inherit.js pass:

chcp 65001 && node test\parallel\test-child-process-stdio-inherit.js
Active code page: 65001
Not enough memory.
... AssertionError: '' === 'asdfasdf' ...

chcp 1252 && node test\parallel\test-child-process-stdio-inherit.js
Active code page: 1252
[pass]

It seems currently this is the only test that uses common.spawnCat().

@mscdex mscdex added test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Feb 21, 2017
@joaocgreis
Copy link
Member

Can't this be addressed as a duplicate of #11469 ? If I understand correctly, this is for spawnCat while #11469 is for more directly, but given that spawnCat uses more, the underlying issue is the same, right?

@vsemozhetbyt
Copy link
Contributor Author

@joaocgreis Yeah, I just was not sure if I should combine the issue with the lib and the issue with individual tests. If anybody finds a universal solution, please, close the both issues. Or feel free to close any of them as a duplicate in advance.

@joaocgreis
Copy link
Member

Closing as a duplicate of #11469 .

Thanks @vsemozhetbyt ! If this was an issue in /lib then it would be an issue for users and would have to be addressed differently, but /test/common.js is only used by the tests, so I think this is essentially the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants