Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-intl-no-icu-data.js fails unless node compiled --with-intl=small-icu #12198

Closed
evantorrie opened this issue Apr 4, 2017 · 6 comments
Closed
Labels
i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.

Comments

@evantorrie
Copy link
Contributor

  • Version: 8.0-pre
  • Platform: Linux
  • Subsystem: test

The test-intl-no-icu-data.js unit test added in PR #11255 fails when nodejs is configured/compiled with --with-intl=full-icu. I believe it will also fail when compiled with --with-intl=none and will be flaky with --with-intl=system-icu

We should add guards to this test to skip it if nodejs is compiled with the above options.

@mscdex mscdex added i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. labels Apr 4, 2017
@mscdex
Copy link
Contributor

mscdex commented Apr 4, 2017

@evantorrie Feel free to open a PR to add the skip if you want to take it on.

@evantorrie
Copy link
Contributor Author

Yep, I'll have something ready in the next day.

@thefourtheye
Copy link
Contributor

I compiled with ./configure --without-intl and I got eight test failures.

=== release test-cluster-inspector-debug-port ===
Path: parallel/test-cluster-inspector-debug-port
assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: 5858 === 13046
    at Object.<anonymous> (/Users/thefourtheye/git/node/test/parallel/test-cluster-inspector-debug-port.js:23:10)
    at Module._compile (module.js:607:30)
    at Object.Module._extensions..js (module.js:618:10)
    at Module.load (module.js:516:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.runMain (module.js:643:10)
    at run (bootstrap_node.js:441:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:569:3
Command: out/Release/node /Users/thefourtheye/git/node/test/parallel/test-cluster-inspector-debug-port.js
=== release test-intl-no-icu-data ===
Path: parallel/test-intl-no-icu-data
out/Release/node: bad option: --icu-data-dir=test/fixtures/empty/
Command: out/Release/node --icu-data-dir=test/fixtures/empty/ /Users/thefourtheye/git/node/test/parallel/test-intl-no-icu-data.js
=== release test-url-domain-ascii-unicode ===
Path: parallel/test-url-domain-ascii-unicode
assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: 'ıídيٴ' === 'xn--d-iga7ro0q9f'
    at domainWithASCII.forEach (/Users/thefourtheye/git/node/test/parallel/test-url-domain-ascii-unicode.js:24:3)
    at Array.forEach (native)
    at Object.<anonymous> (/Users/thefourtheye/git/node/test/parallel/test-url-domain-ascii-unicode.js:20:17)
    at Module._compile (module.js:607:30)
    at Object.Module._extensions..js (module.js:618:10)
    at Module.load (module.js:516:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.runMain (module.js:643:10)
    at run (bootstrap_node.js:441:7)
Command: out/Release/node /Users/thefourtheye/git/node/test/parallel/test-url-domain-ascii-unicode.js
=== release test-url-format-whatwg ===
Path: parallel/test-url-format-whatwg
assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: 'http://xn--lck1c3crb1723bpq4a.com/a?a=b#c' === 'http://理容ナカムラ.com/a?a=b#c'
    at Object.<anonymous> (/Users/thefourtheye/git/node/test/parallel/test-url-format-whatwg.js:79:8)
    at Module._compile (module.js:607:30)
    at Object.Module._extensions..js (module.js:618:10)
    at Module.load (module.js:516:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.runMain (module.js:643:10)
    at run (bootstrap_node.js:441:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:569:3
Command: out/Release/node /Users/thefourtheye/git/node/test/parallel/test-url-format-whatwg.js
=== release test-inspector ===
Path: inspector/test-inspector
[err] Inspector support is not available with this Node.js build
AssertionError: Inspector support is not available with this Node.js build
    at makeBufferingDataCallback (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:467:12)
    at Socket.<anonymous> (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:116:7)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at readableAddChunk (_stream_readable.js:195:18)
    at Socket.Readable.push (_stream_readable.js:153:10)
    at Pipe.onread (net.js:581:20)
Command: out/Release/node /Users/thefourtheye/git/node/test/inspector/test-inspector.js
=== release test-inspector-ip-detection ===
Path: inspector/test-inspector-ip-detection
[err] Inspector support is not available with this Node.js build
AssertionError: Inspector support is not available with this Node.js build
    at makeBufferingDataCallback (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:467:12)
    at Socket.<anonymous> (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:116:7)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at readableAddChunk (_stream_readable.js:195:18)
    at Socket.Readable.push (_stream_readable.js:153:10)
    at Pipe.onread (net.js:581:20)
Command: out/Release/node /Users/thefourtheye/git/node/test/inspector/test-inspector-ip-detection.js
=== release test-not-blocked-on-idle ===
Path: inspector/test-not-blocked-on-idle
[err] Inspector support is not available with this Node.js build
AssertionError: Inspector support is not available with this Node.js build
    at makeBufferingDataCallback (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:467:12)
    at Socket.<anonymous> (/Users/thefourtheye/git/node/test/inspector/inspector-helper.js:116:7)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at readableAddChunk (_stream_readable.js:195:18)
    at Socket.Readable.push (_stream_readable.js:153:10)
    at Pipe.onread (net.js:581:20)
Command: out/Release/node /Users/thefourtheye/git/node/test/inspector/test-not-blocked-on-idle.js
=== release test-debugger-debug-brk ===
Path: sequential/test-debugger-debug-brk
assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: 0 == true
    at ChildProcess.fail (/Users/thefourtheye/git/node/test/sequential/test-debugger-debug-brk.js:10:3)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12)
Command: out/Release/node /Users/thefourtheye/git/node/test/sequential/test-debugger-debug-brk.js
[01:17|% 100|+ 1455|-   8]: Done

@richardlau
Copy link
Member

richardlau commented Apr 5, 2017

I saw four failures back in Feb (#11255 (comment)) so it has regressed further. We don't currently test non-intl builds on the CI (nodejs/build#419).

@evantorrie
Copy link
Contributor Author

evantorrie commented Apr 5, 2017

#12226 addresses only the test-intl-no-icu-data.js test.

The other tests that are failing when Intl is not true can be addressed in a separate PR.

@Trott
Copy link
Member

Trott commented Aug 5, 2017

test-intl-no-icu-data doesn't exist anymore so this specific issue seems close-able. Feel free to comment or re-open (if GitHub lets you) if I'm mistaken.

Additionally, I compiled node without intl and all tests passed so it looks like that was taken care of at some point as well.

@Trott Trott closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants