-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-intl-no-icu-data.js fails unless node compiled --with-intl=small-icu #12198
Comments
@evantorrie Feel free to open a PR to add the skip if you want to take it on. |
Yep, I'll have something ready in the next day. |
I compiled with
|
I saw four failures back in Feb (#11255 (comment)) so it has regressed further. We don't currently test non-intl builds on the CI (nodejs/build#419). |
#12226 addresses only the The other tests that are failing when Intl is not true can be addressed in a separate PR. |
Additionally, I compiled node without intl and all tests passed so it looks like that was taken care of at some point as well. |
The
test-intl-no-icu-data.js
unit test added in PR #11255 fails when nodejs is configured/compiled with--with-intl=full-icu
. I believe it will also fail when compiled with--with-intl=none
and will be flaky with--with-intl=system-icu
We should add guards to this test to skip it if nodejs is compiled with the above options.
The text was updated successfully, but these errors were encountered: