Any way to bypass querystring.stringify with empty Object ?

[jy95]

I am working currently on a project that requires to send custom GET HTTP requests.

I am using the default querystring builder (https://nodejs.org/api/querystring.html)

const querystring = require('querystring');

The problem is for Object (probably also for empty array) such as

{ "extendTypes":{} }  

is serialiazed as :

extendTypes=

The expected result :

extendTypes={}

or its URI encoded version :

extendTypes%3D%7B%7D

So , how can I ever hope to do that ? Any way to bypass this default behalvior ?

Here is my full code if you want :

function generateGetRequest(dataMap, url) {

    let queryParams = {};
    let uriParams = {};

    for (let [key, value] of dataMap) {

        // if value is an object or an array
        if (value instanceof Object || value instanceof Array) {
            uriParams[key] = value;
        } else {
            // param working for superagent
            queryParams[key] = value;
        }

    }
    let queryParamsUri = querystring.stringify(uriParams);
    console.log(queryParamsUri);
    let finalUrl = url + ( (Object.keys(uriParams).length > 0) ? "?" + queryParamsUri : "");
}

• Version: 6.9.4
• Platform: Windows 10

[aqrln]

https://github.com/nodejs/help, https://gitter.im/nodejs/node and #node.js channel on IRC are better places to ask such questions. FWIW, you probably want to pass a JSON string as the value of extendTypes.

I believe the behavior of querystring.stringify() is absolutely correct and it produces the result I'd expect it to, but I agree that the documentation may be improved.

[jy95]

I agree with you about the documentation. As least , why not provide a list of value that will not be seriliazed ? I don't think there are so many cases
For example :

undefined
null
''
""
{}
[]

[joyeecheung]

Yeah it's more like a doc issue. Though I think this should be a list of values that will be serialized instead of values that will not be serialized? (logic is in

node/lib/querystring.js

Lines 219 to 268 in cfc8422

	function stringifyPrimitive(v) {
	if (typeof v === 'string')
	return v;
	if (typeof v === 'number' && isFinite(v))
	return '' + v;
	if (typeof v === 'boolean')
	return v ? 'true' : 'false';
	return '';
	}
	function stringify(obj, sep, eq, options) {
	sep = sep || '&';
	eq = eq || '=';
	var encode = QueryString.escape;
	if (options && typeof options.encodeURIComponent === 'function') {
	encode = options.encodeURIComponent;
	}
	if (obj !== null && typeof obj === 'object') {
	var keys = Object.keys(obj);
	var len = keys.length;
	var flast = len - 1;
	var fields = '';
	for (var i = 0; i < len; ++i) {
	var k = keys[i];
	var v = obj[k];
	var ks = encode(stringifyPrimitive(k)) + eq;
	if (Array.isArray(v)) {
	var vlen = v.length;
	var vlast = vlen - 1;
	for (var j = 0; j < vlen; ++j) {
	fields += ks + encode(stringifyPrimitive(v[j]));
	if (j < vlast)
	fields += sep;
	}
	if (vlen && i < flast)
	fields += sep;
	} else {
	fields += ks + encode(stringifyPrimitive(v));
	if (i < flast)
	fields += sep;
	}
	}
	return fields;
	}
	return '';
	}

, so it's basically just: strings, finite numbers, booleans, and arrays of them).

Labeld as good first contribution. Feel free to send in a doc PR.

[shubheksha]

Can I take this up?

[addaleax]

@shubheksha Go for it! Let us know if you need any help. :)

[jy95]

@shubheksha thanks.

[refack]

Closed by #12313