Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX: fs-watch backport issues #13070

Closed
mhdawson opened this issue May 17, 2017 · 10 comments
Closed

AIX: fs-watch backport issues #13070

mhdawson opened this issue May 17, 2017 · 10 comments
Labels
aix Issues and PRs related to the AIX platform. fs Issues and PRs related to the fs subsystem / file system.

Comments

@mhdawson
Copy link
Member

mhdawson commented May 17, 2017

Seems that there are some problems with the backport for PRs related to improved support for fs-watch on AIX.

  • Version: v6.x
  • Platform: AIX
  • Subsystem: fs

The following tests are failing:

https://ci.nodejs.org/job/node-test-commit-aix/5898/nodes=aix61-ppc64/console

Myles tried landing the PRs what should address these issues but it did not resolve. @gireeshpunathil since you worked the original issues in master can you take a look and document the set of PRs that need to be pulled back for v6.x

@mhdawson mhdawson assigned mhdawson and unassigned mhdawson May 17, 2017
@gireeshpunathil
Copy link
Member

sure, will do

@mscdex mscdex added aix Issues and PRs related to the AIX platform. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels May 17, 2017
@gireeshpunathil
Copy link
Member

@mscdex - I don't think this is a test issue - rather, may have to do with the complexities w.r.t AHAFS file system in AIX.

@mscdex mscdex removed the test Issues and PRs related to the tests. label May 17, 2017
@gireeshpunathil
Copy link
Member

Tracing the merge activities by looking through https://ci.nodejs.org/job/node-test-commit-aix/5898/nodes=aix61-ppc64/consoleFull I am not sure I follow all the steps.

I applied

657c1bf of libuv (changes required to work fs watch)
and
be43a1e of node (changes required to include fs watch tests)

on branch v6.10.1-pre

and was able to build and run the tests successfully.

Were these merged?
Was this branch used? if it is different let me know, I will try that to see if any issue comes up.

@gibfahn
Copy link
Member

gibfahn commented May 17, 2017

Is this a duplicate of nodejs/Release#218? If so that's been closed.

EDIT: Looks like a separate but related issue.

@gibfahn
Copy link
Member

gibfahn commented May 17, 2017

@gireeshpunathil the branch used was v6.11.0-proposal, see also #13059 (the v6.11.0 PR).

@gibfahn
Copy link
Member

gibfahn commented May 17, 2017

Looked at this with @gireeshpunathil, the problem is that the libuv commit to fix fs watch on AIX landed in libuv 1.11.0, which hasn't yet been backported to v6.x (see #11094).

@mhdawson
Copy link
Member Author

Ok, so sounds like we should just wait to backport the changes to the fs-watch tests for AIX until we pull in libuv 1.11.0

@mhdawson
Copy link
Member Author

FYI @MylesBorins

@MylesBorins
Copy link
Contributor

I've backported libuv 1.11.0 to v6.x and rebased the history of v6.11.0 to apply the test changes in the correct order.

CI is green: https://ci.nodejs.org/job/node-test-pull-request/8138/

@gireeshpunathil
Copy link
Member

@MylesBorins - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

No branches or pull requests

5 participants