-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIX: fs-watch backport issues #13070
Comments
sure, will do |
@mscdex - I don't think this is a test issue - rather, may have to do with the complexities w.r.t AHAFS file system in AIX. |
Tracing the merge activities by looking through https://ci.nodejs.org/job/node-test-commit-aix/5898/nodes=aix61-ppc64/consoleFull I am not sure I follow all the steps. I applied 657c1bf of libuv (changes required to work fs watch) on branch v6.10.1-pre and was able to build and run the tests successfully. Were these merged? |
EDIT: Looks like a separate but related issue. |
@gireeshpunathil the branch used was v6.11.0-proposal, see also #13059 (the v6.11.0 PR). |
Looked at this with @gireeshpunathil, the problem is that the libuv commit to fix fs watch on AIX landed in libuv 1.11.0, which hasn't yet been backported to v6.x (see #11094). |
Ok, so sounds like we should just wait to backport the changes to the fs-watch tests for AIX until we pull in libuv 1.11.0 |
FYI @MylesBorins |
I've backported libuv 1.11.0 to v6.x and rebased the history of v6.11.0 to apply the test changes in the correct order. CI is green: https://ci.nodejs.org/job/node-test-pull-request/8138/ |
@MylesBorins - thanks! |
Seems that there are some problems with the backport for PRs related to improved support for fs-watch on AIX.
The following tests are failing:
https://ci.nodejs.org/job/node-test-commit-aix/5898/nodes=aix61-ppc64/console
Myles tried landing the PRs what should address these issues but it did not resolve. @gireeshpunathil since you worked the original issues in master can you take a look and document the set of PRs that need to be pulled back for v6.x
The text was updated successfully, but these errors were encountered: