-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degradation of performance console.log on master #19977
Comments
Possibly related to #19405? |
That is indeed somewhat related. The problem here is that the object is huge. It is quite a lot of work to compute that. Before, there was no circular check because the object depth was already reached before. This will also fail on Node.js 8 or 9 if the util.inspect depth is set to 4 or higher. I plan on limiting the object keys printed by default to 100 just like it is done with arrays. That would also solve the problem here. I am going to wrap my head around finding a even nicer solution also by checking what is using most memory in this case. |
I had a look at the performance and about 90% of the time is spend calling |
Similar to #19405 |
This specific issue got fixed by #20007. |
@ex1st this is how your example runs on my machine with the mentioned patch applied:
|
8.10.0 - performed immediately
master (V8 6.6 and V8 6.5 both) - utilized 100% CPU and frozen for a long time and crashed process.
I think a problem with resolving circular links.
The text was updated successfully, but these errors were encountered: