Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help to backport crypto changes to v10.x-staging #20691

Closed
targos opened this issue May 12, 2018 · 5 comments
Closed

Need help to backport crypto changes to v10.x-staging #20691

targos opened this issue May 12, 2018 · 5 comments
Labels
crypto Issues and PRs related to the crypto subsystem.

Comments

@targos
Copy link
Member

targos commented May 12, 2018

Because of recent semver-major changes that couldn't make it to Node 10, almost every new change to crypto code now has conflicts.

Here is the list of commits that need to be backported:

/cc @nodejs/crypto

@targos targos added crypto Issues and PRs related to the crypto subsystem. v10.x labels May 12, 2018
@ryzokuken
Copy link
Contributor

@targos Consider me in on the effort. We could begin by making a checklist of sorts.

@tniessen
Copy link
Member

I will try to backport my changes as soon as possible, I have been a bit busy the last few weeks, sorry.

@danbev
Copy link
Contributor

danbev commented May 13, 2018

I'll take a look at mine next week.

@targos
Copy link
Member Author

targos commented May 13, 2018

Thank you all. Note that the list is in the order of the commits on master. It will probably be easier to do the backports in the same order.

@tniessen
Copy link
Member

I opened #20706, please take a look.

@targos targos closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants