Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unclear error with _toc.html #21912

Closed
mcollina opened this issue Jul 20, 2018 · 4 comments
Closed

test: unclear error with _toc.html #21912

mcollina opened this issue Jul 20, 2018 · 4 comments
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Comments

@mcollina
Copy link
Member

  • Version: master
  • Platform: OS X
  • Subsystem: doc

I'm adding a new error code, and I'm getting:

=== release test-make-doc ===
Path: doctool/test-make-doc
assert.js:338
    throw err;
    ^

AssertionError [ERR_ASSERTION]: _toc.html does not not match TOC
    at Object.<anonymous> (/Users/matteo/Repositories/node/test/doctool/test-make-doc.js:45:10)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:266:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3)
Command: out/Release/node /Users/matteo/Repositories/node/test/doctool/test-make-doc.js

Considering that _toc.md was deleted in #21637, what should I do to fix this?

cc @rubys

@rubys
Copy link
Member

rubys commented Jul 20, 2018

Delete it, and run the build again. :-)

@targos
Copy link
Member

targos commented Jul 20, 2018

rm -rf out/doc

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 20, 2018
@mcollina
Copy link
Member Author

Can we add the instructions rm -rf out/doc to the error message? It would be very helpful!

@lundibundi
Copy link
Member

I think this can be closed as #21913 that somewhat address this has landed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants