Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate test/tick-processor/test-tick-processor-builtin failures #25891

Closed
Trott opened this issue Feb 2, 2019 · 5 comments
Closed

investigate test/tick-processor/test-tick-processor-builtin failures #25891

Trott opened this issue Feb 2, 2019 · 5 comments
Labels
confirmed-bug Issues with confirmed bugs. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Feb 2, 2019

  • Version: v12.0.0-pre (master branch at 28c0f84
  • Platform: macOS 10.14.2 (Mojave): Darwin LIB-0F7FVH8-LT 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
  • Subsystem: test

test/tick-processor/test-tick-processor-builtin.js fails consistently for me. Since this test is not run in CI or typically locally (unless you run make test-tick-processor, which almost no one does, or the brand new make test-all-suites), it may be broken everywhere. Or maybe it's just me. Anyone?

/ping @indutny who has the biggest git blame footprint on that file (sorry if that's a bad metric to use and I'm pinging the wrong person)

@Trott Trott added the test Issues and PRs related to the tests. label Feb 2, 2019
@Trott
Copy link
Member Author

Trott commented Feb 2, 2019

Running the tick-processorsuite at https://ci.nodejs.org/job/node-test-commit-custom-suites/857/.

@Trott
Copy link
Member Author

Trott commented Feb 2, 2019

It passed in the coverage job at https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage-daily/28/nodes=benchmark/ and in the CI above.

Last thing: Can someone with macOS Mojave try running it? If it passes for someone else on Mojave, I'm OK closing this as my own personal computer's issue. @nodejs/platform-macos

@bnoordhuis
Copy link
Member

At commit 28c0f84:

$ uname -a
Darwin hermes.local 18.0.0 Darwin Kernel Version 18.0.0: Wed Aug 22 20:13:40 PDT 2018; root:xnu-4903.201.2~1/RELEASE_X86_64 x86_64

$ for i in {1..10}; do python tools/test.py tick-processor/test-tick-processor-builtin; done
[00:07|% 100|+   1|-   0]: Done                               
[00:07|% 100|+   1|-   0]: Done                               
=== release test-tick-processor-builtin ===                   
Path: tick-processor/test-tick-processor-builtin
(node:28618) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"code-creation,Builtin,3,142451,0x100e90000" at the file end is broken
(node:28786) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tic" at the file end is broken
(node:28954) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick" at the file end is broken
(node:29122) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tic" at the file end is broken
(node:29794) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick" at the file end is broken
(node:30046) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick" at the file end is broken
(node:30634) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tic" at the file end is broken
Command: out/Release/node /Users/bnoordhuis/src/v1.x/test/tick-processor/test-tick-processor-builtin.js
--- TIMEOUT ---
[02:00|% 100|+   0|-   1]: Done                               
[00:09|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                               
[00:08|% 100|+   1|-   0]: Done                     

Note the 'tic' vs. 'tick'.

@Trott Trott added the confirmed-bug Issues with confirmed bugs. label Feb 3, 2019
@targos
Copy link
Member

targos commented Jun 13, 2020

is this still an issue?

@bnoordhuis
Copy link
Member

Possibly... testing today, the test doesn't terminate in any reasonable time frame:

$ ./out/Release/node test/tick-processor/test-tick-processor-builtin.js
(node:49313) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"code-creation,Builtin,3,129226,0x100a940a0,12,Da" at the file end is broken
(Use `node --trace-warnings ...` to show where the warning was created)
(node:49733) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick" at the file end is broken
(Use `node --trace-warnings ...` to show where the warning was created)
(node:49985) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tic" at the file end is broken
(Use `node --trace-warnings ...` to show where the warning was created)
(node:50582) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick,0x10057ee7e," at the file end is broken
(Use `node --trace-warnings ...` to show where the warning was created)
(node:50672) [BROKEN_PROFILE_FILE] Warning: Profile file /Users/bnoordhuis/src/v1.x/test/.tmp.0/tick-processor.log is broken
"tick" at the file end is broken
# etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants