assertion error in _http_client.js

[Trott]

• Version: v12.0.0-pre (master branch)
• Platform: macOS Mojave, but probably irrelevant
• Subsystem: http

This code causes an assertion error in _http_client.js. Not sure if monkey-patching should be prevented or if the assertion should be a throw instead. But obviously it shouldn't be possible to trigger it.

'use strict';

const http = require('http');

const server = http.createServer((req, res) => {
  res.writeHead(200, { 'Content-Type': 'text/plain' });
  res.end('okay');
});

server.listen(1337, '127.0.0.1');

const req = http.request({
  port: 1337,
  host: '127.0.0.1',
  method: 'GET',
});

req.write('');
req.end(() => { delete req.socket.parser; });

@nodejs/http

[lpinca]

I'm not a fan of defensive code. Anyone doing this is explicitly trying to break things.

[lpinca]

Possibly related issue: #26351

[jasnell]

I know it's been a while but I have to agree with @lpinca's comment. I wouldn't say this is actionable.