Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: ClientRequest.destroy does not take agent into account #28686

Closed
ronag opened this issue Jul 14, 2019 · 1 comment
Closed

http: ClientRequest.destroy does not take agent into account #28686

ronag opened this issue Jul 14, 2019 · 1 comment
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jul 14, 2019

destroy should probably behave like abort and 'free' the socket instead of destroying it. Not sure if this actually causes problems or whether it just is a performance thing.
@ronag ronag mentioned this issue Jul 14, 2019
Closed
4 tasks
@lpinca lpinca added the http Issues or PRs related to the http subsystem. label Jul 28, 2019
@ronag ronag mentioned this issue Aug 24, 2019
Closed
4 tasks
@ronag
Copy link
Member Author

ronag commented Apr 19, 2020

This has been resolved.

@ronag ronag closed this as completed Apr 19, 2020
@Baby12349 Baby12349 mentioned this issue Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpinca @ronag