You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometime between node@v11.15.0 and node@12.0.0 , NODE_V8_COVERAGE seems to have stopped outputting if a script throws in the first tick, as an example:
I've noticed, similarly, that prepareStackTrace appears to not be called, which is why I'm using timeouts in the tests here; I wonder if the root cause might be the same.
The text was updated successfully, but these errors were encountered:
bcoe
added
inspector
Issues and PRs related to the V8 inspector protocol
coverage
Issues and PRs related to native coverage support.
labels
Sep 15, 2019
bcoe
changed the title
NODE_V8_COVERAGE not output Error thrown during initialization
NODE_V8_COVERAGE not output when Error thrown during initialization
Sep 15, 2019
I debugged the prepareStackTrace, the problem is that the sourceMapCache I've been working on is keyed on the module, which does not get placed in the cache on a compile failure.
Have not dug into coverage, but unrelated issue it would seem.
So that coverage, .etc are properly written in case of a normal
fatal exception.
PR-URL: #29611Fixes: #29570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
12.0.0
->12.9.1
.Sometime between
node@v11.15.0
andnode@12.0.0
,NODE_V8_COVERAGE
seems to have stopped outputting if a script throws in the first tick, as an example:This script will output coverage:
I've noticed, similarly, that
prepareStackTrace
appears to not be called, which is why I'm using timeouts in the tests here; I wonder if the root cause might be the same.CC: @addaleax, @joyeecheung, @devsnek, @nodejs/testing
The text was updated successfully, but these errors were encountered: