Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable.from has incomplete version metadata in API docs #32638

Closed
kzar opened this issue Apr 3, 2020 · 1 comment
Closed

Readable.from has incomplete version metadata in API docs #32638

kzar opened this issue Apr 3, 2020 · 1 comment

Comments

@kzar
Copy link
Contributor

kzar commented Apr 3, 2020

  • Version: 10.19.0
  • Platform: Debian (Testing)

Background

The API docs list 12.3.0 as the first Node.js version which supports Readable.from, but it was since backported to 10.17.0. Readable.from is also listed in the v10.x API docs.

Notes:

What to change

Adjust the version metadata for Readable.from to be a list containing both 10.17.0 and 12.3.0.
According to the changelogs 10.17.0 was the first supported version but I haven't verified that.

@kzar kzar changed the title Readable.from has wrong version metadata in API docs Readable.from has incomplete version metadata in API docs Apr 3, 2020
@addaleax
Copy link
Member

addaleax commented Apr 5, 2020

This was fixed by #32639

@addaleax addaleax closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants