-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs.open() can keep the event loop open in some cases #34266
Comments
@nodejs/fs |
"should not be held open" I assume? |
Yes, indeed. Fixed. Thanks! |
@bnoordhuis Are you still interested in investigating this? (Ref: #34228 (review)) And if so, do you need help getting set up with ssh access to one of the Raspberry Pi devices or is that already sorted out? |
This appears to have been addressed by #35566, I will keeping an eye on the next few builds to make sure it's not a still a flake. |
What steps will reproduce the bug?
See test-fs-open-no-close.js added to known_issues in #34228.
How often does it reproduce? Is there a required condition?
I strongly suspect the issue is that the filesystem is NFS-mounted.
What is the expected behavior?
The event loop should not be held open and the test should exit.
What do you see instead?
On the Raspberry Pi devices in CI, the test file times out because it never exits.
Additional information
The text was updated successfully, but these errors were encountered: