Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need CMakeLists.txt #35118

Closed
anlexN opened this issue Sep 9, 2020 · 11 comments
Closed

we need CMakeLists.txt #35118

anlexN opened this issue Sep 9, 2020 · 11 comments
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@anlexN
Copy link
Contributor

anlexN commented Sep 9, 2020

node source code why not have CMakeLists.txt like libuv source code? please give me one.

@mmarchini
Copy link
Contributor

We have a strategic initiative to move from gyp to something else, possibly CMake: nodejs/TSC#901. It'll take some time to get it right though

@bnoordhuis
Copy link
Member

Closing as duplicate.

@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. labels Sep 9, 2020
@anlexN
Copy link
Contributor Author

anlexN commented Sep 10, 2020

@mmarchini i think that give up gyp and anything about python is good idea. so when to migrate? how many days?

@mmarchini
Copy link
Contributor

how many days?

We're talking a couple years probably, that's not something that can be done in a single PR or in a single version.

@anlexN
Copy link
Contributor Author

anlexN commented Sep 12, 2020

@mmarchini you can talk and talk for many days! but can you first give me CMakeLists.txt? i can not open node source code in jetbrains clion! oh my god. please help me. what IDE do you use?

@mmarchini
Copy link
Contributor

As mentioned before, adding CMake support is not something we can rush, nor is it an easy task that can be accomplished quickly.

To build Node.js you can follow the instructions on our build guide: https://github.com/nodejs/node/blob/master/BUILDING.md, it contains the appropriate steps and dependencies for each operating system.

@anlexN
Copy link
Contributor Author

anlexN commented Sep 12, 2020

what IDE do you use? can you teach me how to open node source code in jetbrains clion?

@bnoordhuis
Copy link
Member

FWIW, I attempted a port to cmake a few years ago: https://github.com/bnoordhuis/io.js/tree/cmake

The size of the diff says something about the amount of work involved, and ^ supports maybe 50% of the features that the gyp build supports.

@mmarchini
Copy link
Contributor

I use VSCode + terminal. Just "opening the Node.js source code" should be possible regardless of build system, building it might depend on that's available on Jetbrains. I'm not familiar with Jetbrains specifically so if it has some different requirements I won't be able to help. Working on Node.js with Jetbrains seems to be worth a separate issue though, I suggest opening a new one with as much information as you can provide so other folks can help.

@anlexN
Copy link
Contributor Author

anlexN commented Sep 13, 2020

@bnoordhuis can you support 100% features?
@mmarchini libuv source repo have CMakeLists.txt, i believe that node should have one too. we should unify build system. no libuv, no node.

@bnoordhuis
Copy link
Member

If I had infinite time and patience, sure, but I have neither.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

3 participants