The default CallJS method of ThreadSafeFunction ignores user exceptions

[mmomtchev]

Version

All

Platform

All

Subsystem

node-api

What steps will reproduce the bug?

Throw a JS exception from an async callback called through ThreadSafeFunction as described here: nodejs/node-addon-api#669

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Node exits cleanly reporting an unhandled exception: nodejs/node-addon-api#1119

What do you see instead?

Node continues as if nothing happened

Additional information

The exceptions are ignored here:

node/src/node_api.cc

Line 401 in 55c5120

if (status != napi_ok && status != napi_pending_exception) {

[mhdawson]

@mmomtchev I think this is related to #36510 and we are working on landing a fix.

[mhdawson]

@mmomtchev this should now be resolved since #36510 landed. Can you please check and let us know?

[mmomtchev]

No, the unit test doesn't use the builtin CallJS which is used only when a ThreadSafeFunction is created without a custom callback - which is possible only by directly using Node-API without node-addon-api. CallJS hasn't changed and the unit test from the PR uses napi_call_function without creating a ThreadSafeFunction.

But it does implement everything needed - the only thing missing is to attach the new code in node_napi_env__::CallbackIntoModule to the builtin CallJS in node_api.cc.

[mmomtchev]

In fact works, the exception being handled at

node/src/js_native_api_v8.h

Line 91 in b6a2072

if (!last_exception.IsEmpty()) {

(I am sorry but a Debug build takes 4 hours on my machine + 10 minutes to load it in gdb)