-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: utf8 fast paths don't accept all valid utf8 values #49888
Comments
Seems there needs to be a call to normalizeEncoding |
I don't think that would be needed, there's only 4 cases where that returns |
yeah, but you could also have mixed cases, like 'Utf-8' right? |
Oh right as a final check. I don't think fast paths should have to worry about that for now at least as I doubt it's common and would add measurable overhead? |
I once wrote for testing all permutations of uppercase/lowercase into a Map and it improved the performance of normalizeEncoding. This sounds like a use case for normalizeEncoding. |
UTF8
andUTF-8
are also valid but not accepted by any existing utf8 fast paths (#48658, #49884)The text was updated successfully, but these errors were encountered: