Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about license notice. #5021

Closed
lemmaa opened this issue Feb 1, 2016 · 4 comments
Closed

Question about license notice. #5021

lemmaa opened this issue Feb 1, 2016 · 4 comments
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. question Issues that look for answers.

Comments

@lemmaa
Copy link

lemmaa commented Feb 1, 2016

Hi, I'm Sung-Jae Lee, a leader of IoT.js project. IoT.js was inspired from node.js and referenced basic architecture and some parts of codes from this project to implement node.js compatible API for IoT. Recently, we realized that we had missing license notification for referenced code by accident, and trying to correct it. (jerryscript-project/iotjs#326)

In my understanding from https://github.com/nodejs/node/blob/master/LICENSE, all the source codes in https://github.com/nodejs/node/tree/master/src are under 'node.js license', the first section of LICENSE file. So I appended the 'node.js license' notice to https://github.com/Samsung/iotjs/blob/master/LICENSE, but I can't sure it is sufficient.

So, I leave a question here. Please let me know if I have to do something more.

I'm really appreciate to all the contribution of node.js community in open source.
Thank you in advance! :)

@rvagg
Copy link
Member

rvagg commented Feb 1, 2016

Thanks @lemmaa. The state of our LICENSE is in a little bit of flux at the moment with the exact form that the top part of the file under question and currently in the hands of the legal representatives of the Node.js Foundation. It's a work in progress but being tracked here: #3979.

Be patient with us but we'll leave this issue open and track it in #3979 and report back when we have an answer. I'll make sure we get answers from the legal folks to your exact question because it's probably something we should have a clue about!

@lemmaa
Copy link
Author

lemmaa commented Feb 1, 2016

Thanks @rvagg. We also leave our issue open and following your guide.

@mscdex mscdex added question Issues that look for answers. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 1, 2016
@mikeal
Copy link
Contributor

mikeal commented Mar 21, 2016

@lemmaa update from the Foundation.

Please do not modify copyright lines. It is actually a violation of the MIT license.

If you are making local modifications under your own copyright please add your copyright line below the original.

Also, as a side note, be sure to include the copyright notice and the MIT license in the documentation for any hardware you ship with this code running on it.

@jasnell
Copy link
Member

jasnell commented Apr 22, 2016

Is there reason to leave this one open?

@jasnell jasnell closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

5 participants