Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement issue templates? #5288

Closed
Fishrock123 opened this issue Feb 17, 2016 · 6 comments
Closed

Implement issue templates? #5288

Fishrock123 opened this issue Feb 17, 2016 · 6 comments
Labels
discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

https://github.com/blog/2111-issue-and-pull-request-templates

Is this a thing we should do? If we do, we should try to keep it as simple as possible and try to get some non-english feedback to the questions/options

Edit: Looks like Issues and PRs have different templates available.
Edit: looks like this stuff can go into .github/ so it doesn't clutter the root of the project too much.

@Fishrock123 Fishrock123 added discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project. labels Feb 17, 2016
@MylesBorins
Copy link
Contributor

I for one think this can be a great start. Do we know how it effects PR's coming in that are only one commit?

It would be a shame to lose the ability to automatically copy over the commit message as the PR message... but it might be worth the small pain to make things easier to new comers

@Fishrock123
Copy link
Contributor Author

Hmmm it doesn't seem to specify.

@jasnell
Copy link
Member

jasnell commented Feb 17, 2016

We've never really enforced any kind of common format for issue or pr text... I'm not sure what we would include in a template

@petkaantonov
Copy link
Contributor

The issue template could ask the user if they know what platform and version the issue appears on and if the issue appeared in previous version of node, repro code etc. This wouldn't be enforced but something users can answer to best of their ability for potential time savings that would be lost in the back and forth when asking for this basic info..

@Trott
Copy link
Member

Trott commented Feb 17, 2016

Ref: #5291

@Fishrock123
Copy link
Contributor Author

Now implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

5 participants