Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll phase documentation #9720

Open
LucaFranceschini opened this issue Nov 21, 2016 · 8 comments
Open

Poll phase documentation #9720

LucaFranceschini opened this issue Nov 21, 2016 · 8 comments
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@LucaFranceschini
Copy link

LucaFranceschini commented Nov 21, 2016

  • Version:
  • Platform:
  • Subsystem:

/doc/topics/event-loop-timers-and-nexttick.md
The documentation has been moved (#10792):
https://github.com/nodejs/nodejs.org/blob/master/locale/en/docs/guides/event-loop-timers-and-nexttick.md

The description of the poll phase is not clear at all to me. Could someone please clarify the (sequence of the) operations in this phase?

Examples:

When the event loop enters the poll phase and there are no timers scheduled, one of two things will happen:

Well, what happens if there are timers scheduled?

If scripts have not been scheduled by setImmediate(), the event loop will wait for callbacks to be added to the queue, then execute them immediately.

Until... what?

Once the poll queue is empty [...]

This could not even happen if we reached the system-dependent hard limit, right? Would this step be ignored in such cases?

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Nov 21, 2016
@psypersky
Copy link

+1

2 similar comments
@metalshan
Copy link

+1

@icelancer
Copy link

+1

@bnoordhuis
Copy link
Member

Use upvotes please, don't +1. It sends an unnecessary email to several hundred people.

@sam-github
Copy link
Contributor

sam-github commented Feb 27, 2017

@LucaFranceschini current location: https://github.com/nodejs/nodejs.org/blob/master/locale/en/docs/guides/event-loop-timers-and-nexttick.md

PR that moved it: #10792

@nodejs/documentation Should this issue be reopened against https://github.com/nodejs/nodejs.org ?

@Trott Trott added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jul 27, 2017
@apapirovski
Copy link
Member

@nodejs/documentation This could use some love. It is not exactly incorrect but certainly confusing and somewhat misleading.

@himself65
Copy link
Member

+1 and no one to reedit the docs?

@yuqingc
Copy link

yuqingc commented Oct 5, 2020

nodejs/help#1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests