From bbc1bd4e0d1987ad8fb2357d6180ed3a5a5e8100 Mon Sep 17 00:00:00 2001 From: Kyle Lamse Date: Tue, 18 Jul 2017 14:03:43 -0500 Subject: [PATCH 1/3] doc: add note for Windows build path Fixes: https://github.com/nodejs/node/issues/14337 --- BUILDING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/BUILDING.md b/BUILDING.md index 47630ddf150216..ac71f59723d655 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -174,6 +174,7 @@ Prerequisites: * Basic Unix tools required for some tests, [Git for Windows](http://git-scm.com/download/win) includes Git Bash and tools which can be included in the global `PATH`. +* NOTE: If the path to your home directory contains a space, the build will likely fail. ```console > .\vcbuild From a5911cb8499a3998419c21eb54f9d1fbd5ddc31f Mon Sep 17 00:00:00 2001 From: Kyle Lamse Date: Tue, 18 Jul 2017 14:16:42 -0500 Subject: [PATCH 2/3] Update BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index ac71f59723d655..b09137703c7bf6 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -174,7 +174,7 @@ Prerequisites: * Basic Unix tools required for some tests, [Git for Windows](http://git-scm.com/download/win) includes Git Bash and tools which can be included in the global `PATH`. -* NOTE: If the path to your home directory contains a space, the build will likely fail. +* NOTE: If the path to your build directory contains a space, the build will likely fail. ```console > .\vcbuild From db37320d74f04af98a8efaee39ed83fc317e786d Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 23 Aug 2017 22:05:02 -0700 Subject: [PATCH 3/3] [Squash] Address the nits --- BUILDING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index b09137703c7bf6..4bb417f95615b7 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -93,6 +93,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and * You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid popups asking to accept incoming network connections when running tests: +If the path to your build directory contains a space, the build will likely fail. + ```console $ sudo ./tools/macosx-firewall.sh ``` @@ -174,7 +176,8 @@ Prerequisites: * Basic Unix tools required for some tests, [Git for Windows](http://git-scm.com/download/win) includes Git Bash and tools which can be included in the global `PATH`. -* NOTE: If the path to your build directory contains a space, the build will likely fail. + +If the path to your build directory contains a space, the build will likely fail. ```console > .\vcbuild