Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2,doc: added link definitions to footer in http2.md #14946

Closed
wants to merge 4 commits into from
Closed

http2,doc: added link definitions to footer in http2.md #14946

wants to merge 4 commits into from

Conversation

sharababy
Copy link
Contributor

@sharababy sharababy commented Aug 19, 2017 •
edited
Loading

Fixes: #14857

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 19, 2017
refack
refack approved these changes Aug 19, 2017
View reviewed changes
doc/api/http2.md Outdated
@@ -2598,3 +2598,16 @@ if the stream is closed.
[Readable Stream]: stream.html#stream_class_stream_readable
[`ServerRequest`]: #http2_class_server_request
[`stream.pushStream()`]: #http2_stream-pushstream
[`http2.Server`]: #http2_class_http2server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🥇
While you are here it would be nice if you could sort the whole definition block in "ASCIIbetical" order.

refack
refack reviewed Aug 19, 2017
View reviewed changes
doc/api/http2.md Outdated
[`response.write()`]: #http2_response_write_chunk_encoding_callback
[`response.setHeader()`]: #http2_response_setheader_name_value
[`response.writeHead()`]: #http2_response_writehead_statuscode_statusmessage_headers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could you remove the extra line at the end (try to keep a single \n at the end of the file)

@refack
Copy link
Contributor

refack commented Aug 19, 2017

Hello @sharababy and welcome.
If you haven't already, it's recommended you take a look at CONTRIBUTING.md guide (especialy the part about "discuss and update"). Customarily PRs are kept open for at least 48 hour so that anyone interested gets a chance to comment or review.
Also documentation changes, while easy to do are more difficult to validate. With code we can write tests and the CI can validate the change. With documentation the only way to validate is with human eyes, so don't be dismayed if you get a lot of feedback.
Anyway thank you for the contribution, and good luck 🥇

P.S. If you have any question you can also feel free to contact me directly.

@refack
Copy link
Contributor

refack commented Aug 20, 2017

@sharababy thanks for following up.

@refack
Copy link
Contributor

refack commented Aug 20, 2017 •
edited
Loading

BTW: if you want your full name to show up in the commit logs you should follow: https://help.github.com/articles/setting-your-username-in-git/

jasnell pushed a commit that referenced this pull request Aug 21, 2017
@sharababy @jasnell
doc: fixed link definitions in http2.md footer
f0d8eb6 
PR-URL: #14946
Fixes: #14857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 21, 2017

Landed in f0d8eb6

@jasnell jasnell closed this Aug 21, 2017
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@sharababy @MylesBorins
doc: fixed link definitions in http2.md footer
2494ca2 
PR-URL: #14946
Fixes: #14857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@sharababy @MylesBorins
doc: fixed link definitions in http2.md footer
daae6bc 
PR-URL: #14946
Fixes: #14857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharababy @refack @jasnell @MylesBorins @nodejs-github-bot