From ed7b2cf5dab2aef0ceb611c5041692851a2885da Mon Sep 17 00:00:00 2001 From: Scott J Beck Date: Fri, 6 Oct 2017 09:53:49 -0700 Subject: [PATCH 1/3] test: replace common.fixturesDir with common.fixtures module --- test/parallel/test-https-localaddress-bind-error.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-https-localaddress-bind-error.js b/test/parallel/test-https-localaddress-bind-error.js index a22db1e9e61594..940786d8784f11 100644 --- a/test/parallel/test-https-localaddress-bind-error.js +++ b/test/parallel/test-https-localaddress-bind-error.js @@ -28,9 +28,11 @@ const assert = require('assert'); const fs = require('fs'); const https = require('https'); +const fixtures = require('../common/fixtures'); + const options = { - key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), - cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) + key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), + cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`) }; const invalidLocalAddress = '1.2.3.4'; From 0e0cf26f436c139fc2da33208871f859a51e974c Mon Sep 17 00:00:00 2001 From: Scott J Beck Date: Mon, 23 Oct 2017 13:01:33 -0700 Subject: [PATCH 2/3] test: replace fixturesDir with fixtures module --- test/parallel/test-https-localaddress-bind-error.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-https-localaddress-bind-error.js b/test/parallel/test-https-localaddress-bind-error.js index 940786d8784f11..afe41a66cbc837 100644 --- a/test/parallel/test-https-localaddress-bind-error.js +++ b/test/parallel/test-https-localaddress-bind-error.js @@ -31,8 +31,8 @@ const https = require('https'); const fixtures = require('../common/fixtures'); const options = { - key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), - cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`) + key: fixtures.readKey('agent1-key.pem'), + cert: fixtures.readKey('agent1-cert.pem') }; const invalidLocalAddress = '1.2.3.4'; From 94b4a849418cadfd05d71d6c00eb60cefa67a89f Mon Sep 17 00:00:00 2001 From: Scott J Beck Date: Fri, 27 Oct 2017 07:36:15 -0700 Subject: [PATCH 3/3] removing unused variable fs --- test/parallel/test-https-localaddress-bind-error.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-https-localaddress-bind-error.js b/test/parallel/test-https-localaddress-bind-error.js index afe41a66cbc837..57e4dd054d78ce 100644 --- a/test/parallel/test-https-localaddress-bind-error.js +++ b/test/parallel/test-https-localaddress-bind-error.js @@ -25,7 +25,6 @@ if (!common.hasCrypto) common.skip('missing crypto'); const assert = require('assert'); -const fs = require('fs'); const https = require('https'); const fixtures = require('../common/fixtures');