From 4e596b216ea81d90c3d8657dbf2e9c2dcdce5a65 Mon Sep 17 00:00:00 2001 From: Yang Guo Date: Mon, 17 Sep 2018 07:43:46 +0200 Subject: [PATCH] deps: add missing HandleScope in FieldType::PrintTo Refs: https://github.com/nodejs/node/issues/22775 --- common.gypi | 2 +- deps/v8/src/field-type.cc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index ae8f1935d98d83..3cccb3aca12589 100644 --- a/common.gypi +++ b/common.gypi @@ -29,7 +29,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.11', + 'v8_embedder_string': '-node.12', # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, diff --git a/deps/v8/src/field-type.cc b/deps/v8/src/field-type.cc index 3b51095323c06b..2eebebe3d616ea 100644 --- a/deps/v8/src/field-type.cc +++ b/deps/v8/src/field-type.cc @@ -78,6 +78,7 @@ void FieldType::PrintTo(std::ostream& os) { os << "None"; } else { DCHECK(IsClass()); + HandleScope scope(Map::cast(this)->GetIsolate()); os << "Class(" << static_cast(*AsClass()) << ")"; } }