From deb329b509368fa52dfc7f232be3db39c940df57 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sun, 21 Oct 2018 12:37:26 -0700 Subject: [PATCH 1/3] src: fix missing deprecation assignment --- doc/api/deprecations.md | 15 +++++++++++++++ lib/internal/bootstrap/node.js | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 33e98c4cd4404d..be72ee5aaac071 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2247,6 +2247,21 @@ Type: Documentation-only (supports [`--pending-deprecation`][]) Directly calling `process.binding('uv').errname()` is deprecated. Please make sure to use [`util.getSystemErrorName()`][] instead. + +### DEP0120: Windows Performance Counter Support + + +Windows Performance Counter support has been removed from Node.js. The +undocumented `COUNTER_NET_SERVER_CONNECTION()`, +`COUNTER_NET_SERVER_CONNECTION_CLOSE()`, `COUNTER_HTTP_SERVER_REQUEST()`, +`COUNTER_HTTP_SERVER_RESPONSE()`, `COUNTER_HTTP_CLIENT_REQUEST()`, and +`COUNTER_HTTP_CLIENT_RESPONSE()` functions have been deprecated. + [`--pending-deprecation`]: cli.html#cli_pending_deprecation [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index f0ca57afd4a758..2d99885750fb37 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -222,7 +222,7 @@ enumerable: false, value: deprecate(noop, `COUNTER_${names[n]}() is deprecated.`, - 'DEP00XX') + 'DEP0120') }); } } From 3bab8d8689097fed8ff4c60ab14b4ce4ca76cd48 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sun, 21 Oct 2018 14:37:13 -0700 Subject: [PATCH 2/3] [Squash] nit --- doc/api/deprecations.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index be72ee5aaac071..25ca5be146e826 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2235,7 +2235,7 @@ It will become an error in future versions of Node.js. ### DEP0119: process.binding('uv').errname() private API - +Type: Runtime + Windows Performance Counter support has been removed from Node.js. The undocumented `COUNTER_NET_SERVER_CONNECTION()`, `COUNTER_NET_SERVER_CONNECTION_CLOSE()`, `COUNTER_HTTP_SERVER_REQUEST()`, From 802ab9e71aa54b7e57027a20722f2cf2d5f7c0f1 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Mon, 22 Oct 2018 12:57:47 -0700 Subject: [PATCH 3/3] [Squash] nit Co-Authored-By: jasnell --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 25ca5be146e826..e4955f439250d9 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2259,7 +2259,7 @@ changes: Type: Runtime Windows Performance Counter support has been removed from Node.js. The -undocumented `COUNTER_NET_SERVER_CONNECTION()`, +undocumented `COUNTER_NET_SERVER_CONNECTION()`, `COUNTER_NET_SERVER_CONNECTION_CLOSE()`, `COUNTER_HTTP_SERVER_REQUEST()`, `COUNTER_HTTP_SERVER_RESPONSE()`, `COUNTER_HTTP_CLIENT_REQUEST()`, and `COUNTER_HTTP_CLIENT_RESPONSE()` functions have been deprecated.