From 67002e08362dceb10ef10a7ccfbe1bff11a199c3 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 29 Oct 2018 10:27:34 +0100 Subject: [PATCH 1/2] build: make benchmark/napi all prereq order-only This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. --- Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 88be22fcace3ec..e04610aa175d0d 100644 --- a/Makefile +++ b/Makefile @@ -308,20 +308,20 @@ test-valgrind: all test-check-deopts: all $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential -benchmark/napi/function_call/build/Release/binding.node: all \ +benchmark/napi/function_call/build/Release/binding.node: \ benchmark/napi/function_call/napi_binding.c \ benchmark/napi/function_call/binding.cc \ - benchmark/napi/function_call/binding.gyp - $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ + benchmark/napi/function_call/binding.gyp | all + @$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --python="$(PYTHON)" \ --directory="$(shell pwd)/benchmark/napi/function_call" \ --nodedir="$(shell pwd)" -benchmark/napi/function_args/build/Release/binding.node: all \ +benchmark/napi/function_args/build/Release/binding.node: \ benchmark/napi/function_args/napi_binding.c \ benchmark/napi/function_args/binding.cc \ - benchmark/napi/function_args/binding.gyp - $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ + benchmark/napi/function_args/binding.gyp | all + @$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --python="$(PYTHON)" \ --directory="$(shell pwd)/benchmark/napi/function_args" \ --nodedir="$(shell pwd)" From c7190d9e2841307f2cac9e55d0a6974887c09750 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 30 Oct 2018 05:34:51 +0100 Subject: [PATCH 2/2] squash: remove supression of shell cmd echoing --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index e04610aa175d0d..aa8d75242c00f5 100644 --- a/Makefile +++ b/Makefile @@ -312,7 +312,7 @@ benchmark/napi/function_call/build/Release/binding.node: \ benchmark/napi/function_call/napi_binding.c \ benchmark/napi/function_call/binding.cc \ benchmark/napi/function_call/binding.gyp | all - @$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ + $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --python="$(PYTHON)" \ --directory="$(shell pwd)/benchmark/napi/function_call" \ --nodedir="$(shell pwd)" @@ -321,7 +321,7 @@ benchmark/napi/function_args/build/Release/binding.node: \ benchmark/napi/function_args/napi_binding.c \ benchmark/napi/function_args/binding.cc \ benchmark/napi/function_args/binding.gyp | all - @$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ + $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --python="$(PYTHON)" \ --directory="$(shell pwd)/benchmark/napi/function_args" \ --nodedir="$(shell pwd)"