From d379e453e2b9ed90229a95cac191b467d934ecb1 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sat, 30 Mar 2019 13:07:06 -0400 Subject: [PATCH] build,win: silence MSVC warning C4129 for V8 Currently we get 13,799 of those per build PR-URL: https://github.com/nodejs/node/pull/27017 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater --- tools/v8_gypfiles/toolchain.gypi | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi index 909dfa7970fad5..64914284e7efd7 100644 --- a/tools/v8_gypfiles/toolchain.gypi +++ b/tools/v8_gypfiles/toolchain.gypi @@ -1400,6 +1400,7 @@ }, # configurations 'cflags!': [ '-Wall', '-Wextra' ], 'msvs_disabled_warnings': [ + 4129, # unrecognized character escape sequence (torque-generated) 4245, # Conversion with signed/unsigned mismatch. 4267, # Conversion with possible loss of data. 4324, # Padding structure due to alignment.