From 6bb3112968c3a8eaef36897bdf156972477493aa Mon Sep 17 00:00:00 2001 From: EduardoRFS Date: Sun, 4 Aug 2019 12:54:48 -0300 Subject: [PATCH 1/3] doc: make unshift doc compliant with push doc readable.unshift() also allows to pass null and end stream readable.push() don't allow null when in object mode --- doc/api/stream.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index c7b00f983d83ac..770cc24956ef2a 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1244,13 +1244,15 @@ changes: description: The `chunk` argument can now be a `Uint8Array` instance. --> -* `chunk` {Buffer|Uint8Array|string|any} Chunk of data to unshift onto the +* `chunk` {Buffer|Uint8Array|string|null|any} Chunk of data to unshift onto the read queue. For streams not operating in object mode, `chunk` must be a string, `Buffer` or `Uint8Array`. For object mode streams, `chunk` may be any JavaScript value other than `null`. * `encoding` {string} Encoding of string chunks. Must be a valid `Buffer` encoding, such as `'utf8'` or `'ascii'`. +Passing chunk as null signals the end of the stream (EOF), after which no more data can be written. + The `readable.unshift()` method pushes a chunk of data back into the internal buffer. This is useful in certain situations where a stream is being consumed by code that needs to "un-consume" some amount of data that it has optimistically @@ -2028,7 +2030,7 @@ changes: * `chunk` {Buffer|Uint8Array|string|null|any} Chunk of data to push into the read queue. For streams not operating in object mode, `chunk` must be a string, `Buffer` or `Uint8Array`. For object mode streams, `chunk` may be - any JavaScript value. + any JavaScript value other than `null`.. * `encoding` {string} Encoding of string chunks. Must be a valid `Buffer` encoding, such as `'utf8'` or `'ascii'`. * Returns: {boolean} `true` if additional chunks of data may continue to be From 69798b282d84a344fbae8bfeb25ff1230320786c Mon Sep 17 00:00:00 2001 From: EduardoRFS Date: Sun, 4 Aug 2019 13:16:48 -0300 Subject: [PATCH 2/3] Update doc/api/stream.md Co-Authored-By: mscdex --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index 770cc24956ef2a..355ca337dedfc5 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1251,7 +1251,7 @@ changes: * `encoding` {string} Encoding of string chunks. Must be a valid `Buffer` encoding, such as `'utf8'` or `'ascii'`. -Passing chunk as null signals the end of the stream (EOF), after which no more data can be written. +Passing `chunk` as `null` signals the end of the stream (EOF), after which no more data can be written. The `readable.unshift()` method pushes a chunk of data back into the internal buffer. This is useful in certain situations where a stream is being consumed by From 6234ca39823ae336b8f3b3570c43eb0cc1bd9948 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 6 Aug 2019 10:35:28 -0700 Subject: [PATCH 3/3] fixup! Update doc/api/stream.md --- doc/api/stream.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index 355ca337dedfc5..7d54c92f21003e 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1246,12 +1246,13 @@ changes: * `chunk` {Buffer|Uint8Array|string|null|any} Chunk of data to unshift onto the read queue. For streams not operating in object mode, `chunk` must be a - string, `Buffer` or `Uint8Array`. For object mode streams, `chunk` may be - any JavaScript value other than `null`. + string, `Buffer`, `Uint8Array` or `null`. For object mode streams, `chunk` + may be any JavaScript value. * `encoding` {string} Encoding of string chunks. Must be a valid `Buffer` encoding, such as `'utf8'` or `'ascii'`. -Passing `chunk` as `null` signals the end of the stream (EOF), after which no more data can be written. +Passing `chunk` as `null` signals the end of the stream (EOF), after which no +more data can be written. The `readable.unshift()` method pushes a chunk of data back into the internal buffer. This is useful in certain situations where a stream is being consumed by @@ -2030,7 +2031,7 @@ changes: * `chunk` {Buffer|Uint8Array|string|null|any} Chunk of data to push into the read queue. For streams not operating in object mode, `chunk` must be a string, `Buffer` or `Uint8Array`. For object mode streams, `chunk` may be - any JavaScript value other than `null`.. + any JavaScript value. * `encoding` {string} Encoding of string chunks. Must be a valid `Buffer` encoding, such as `'utf8'` or `'ascii'`. * Returns: {boolean} `true` if additional chunks of data may continue to be