From 2b668e7018d42b62ab91045d3d5efcf40b66da45 Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Mon, 30 Sep 2019 13:56:26 -0400 Subject: [PATCH 1/4] doc: Add Documentation Deprecation for process._tickCallback --- doc/api/deprecations.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 46d2467c7234b8..74f1ad3ecc39d5 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2518,6 +2518,20 @@ Type: Documentation-only Prefer [`response.socket`][] over [`response.connection`] and [`request.socket`][] over [`request.connection`]. + +### DEP0XXX: process._tickCallback + +Type: Documentation-only + +The `process._tickCallback` property was never documented as +an officially supported API. + + [`--pending-deprecation`]: cli.html#cli_pending_deprecation [`--throw-deprecation`]: cli.html#cli_throw_deprecation [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size From c78830880a68371a122585d8aee9e4b887656f75 Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Mon, 30 Sep 2019 14:15:14 -0400 Subject: [PATCH 2/4] squash: add pr-url --- doc/api/deprecations.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 74f1ad3ecc39d5..2886ff9081714d 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2523,7 +2523,7 @@ Prefer [`response.socket`][] over [`response.connection`] and Type: Documentation-only From f868b9cd49ce11f0cb3571b90b604f0dfdf3f08e Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Tue, 1 Oct 2019 06:28:19 -0400 Subject: [PATCH 3/4] squash: fix linting issue --- doc/api/deprecations.md | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 2886ff9081714d..23c43a99b947a0 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2531,7 +2531,6 @@ Type: Documentation-only The `process._tickCallback` property was never documented as an officially supported API. - [`--pending-deprecation`]: cli.html#cli_pending_deprecation [`--throw-deprecation`]: cli.html#cli_throw_deprecation [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size From 6dad852de2d4b55b014abe8fb3d5fe3b6ddb27dc Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Tue, 1 Oct 2019 13:41:54 -0400 Subject: [PATCH 4/4] squash: add a supports --pending-deprecation --- doc/api/deprecations.md | 2 +- lib/internal/bootstrap/pre_execution.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 23c43a99b947a0..a05429decb1385 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2526,7 +2526,7 @@ changes: pr-url: https://github.com/nodejs/node/pull/29781 description: Documentation-only deprecation. --> -Type: Documentation-only +Type: Documentation-only (supports [`--pending-deprecation`][]) The `process._tickCallback` property was never documented as an officially supported API. diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js index 6e7d946458d44e..018a72ad4ad49a 100644 --- a/lib/internal/bootstrap/pre_execution.js +++ b/lib/internal/bootstrap/pre_execution.js @@ -271,6 +271,10 @@ function initializeDeprecations() { process.binding = deprecate(process.binding, 'process.binding() is deprecated. ' + 'Please use public APIs instead.', 'DEP0111'); + + process._tickCallback = deprecate(process._tickCallback, + 'process._tickCallback() is deprecated', + 'DEP0XXX'); } // Create global.process and global.Buffer as getters so that we have a