diff --git a/benchmark/os/homedir.js b/benchmark/os/homedir.js new file mode 100644 index 00000000000000..d48f99dba18a2b --- /dev/null +++ b/benchmark/os/homedir.js @@ -0,0 +1,31 @@ +'use strict'; + +const common = require('../common.js'); +const homedir = require('os').homedir; +const assert = require('assert'); + +const bench = common.createBenchmark(main, { + n: [1e6], +}); + +function main({ n }) { + // Warm up. + const length = 1024; + const array = []; + for (let i = 0; i < length; ++i) { + array.push(homedir()); + } + + bench.start(); + for (let i = 0; i < n; ++i) { + const index = i % length; + array[index] = homedir(); + } + bench.end(n); + + // Verify the entries to prevent dead code elimination from making + // the benchmark invalid. + for (let i = 0; i < length; ++i) { + assert.strictEqual(typeof array[i], 'string'); + } +} diff --git a/benchmark/os/hostname.js b/benchmark/os/hostname.js new file mode 100644 index 00000000000000..9436f23af98c7a --- /dev/null +++ b/benchmark/os/hostname.js @@ -0,0 +1,31 @@ +'use strict'; + +const common = require('../common.js'); +const hostname = require('os').hostname; +const assert = require('assert'); + +const bench = common.createBenchmark(main, { + n: [1e6], +}); + +function main({ n }) { + // Warm up. + const length = 1024; + const array = []; + for (let i = 0; i < length; ++i) { + array.push(hostname()); + } + + bench.start(); + for (let i = 0; i < n; ++i) { + const index = i % length; + array[index] = hostname(); + } + bench.end(n); + + // Verify the entries to prevent dead code elimination from making + // the benchmark invalid. + for (let i = 0; i < length; ++i) { + assert.strictEqual(typeof array[i], 'string'); + } +} diff --git a/benchmark/os/uptime.js b/benchmark/os/uptime.js new file mode 100644 index 00000000000000..2f25dfe670b722 --- /dev/null +++ b/benchmark/os/uptime.js @@ -0,0 +1,31 @@ +'use strict'; + +const common = require('../common.js'); +const uptime = require('os').uptime; +const assert = require('assert'); + +const bench = common.createBenchmark(main, { + n: [1e5], +}); + +function main({ n }) { + // Warm up. + const length = 1024; + const array = []; + for (let i = 0; i < length; ++i) { + array.push(uptime()); + } + + bench.start(); + for (let i = 0; i < n; ++i) { + const index = i % length; + array[index] = uptime(); + } + bench.end(n); + + // Verify the entries to prevent dead code elimination from making + // the benchmark invalid. + for (let i = 0; i < length; ++i) { + assert.strictEqual(typeof array[i], 'number'); + } +} diff --git a/lib/os.js b/lib/os.js index 34391697b5891c..1ad17c635182d4 100644 --- a/lib/os.js +++ b/lib/os.js @@ -61,9 +61,9 @@ const { } = internalBinding('os'); function getCheckedFunction(fn) { - return hideStackFrames(function checkError(...args) { + return hideStackFrames(function checkError() { const ctx = {}; - const ret = fn(...args, ctx); + const ret = fn(ctx); if (ret === undefined) { throw new ERR_SYSTEM_ERROR(ctx); }