From f95cc96c684b4974923d765c67d58cb389c2f853 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 15:48:00 -0500 Subject: [PATCH 01/23] github: add issue and pull request templates Fix: #5246 --- .github/ISSUE_TEMPLATE.md | 43 ++++++++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 38 ++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000000000..6ad7b4f5123a11 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,43 @@ +### Issue details + +_Please provide issue details here_. + +### Steps to reproduce/test case + +_Please provide necessary steps for reproduction of this issue, or better the +reduced test case (without any external dependencies)_. + +### Affected node.js versions + +- [ ] v0.10 +- [ ] v0.12 +- [ ] v4.x +- [ ] v5.x +- [ ] master + +### Affected platforms + +- [ ] linux +- [ ] windows +- [ ] OS X +- [ ] freebsd +- [ ] solaris +- [ ] other _(please specify which)_ + +### Core part (if known) + +- [ ] buffer +- [ ] child_process +- [ ] cluster +- [ ] crypto +- [ ] dgram +- [ ] dns +- [ ] fs +- [ ] http +- [ ] https +- [ ] net +- [ ] tls +- [ ] tty +- [ ] vm +- [ ] zlib +- [ ] other _(please specify which)_ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000000000..e80c4998e3c5da --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,38 @@ +### Description of change + +_Please provide description of change here_. + +### Pull Request check-list + +_Please make sure to review and check all of these items_: + +- [ ] Does `make test` pass after this change? +- [ ] Is commit message formatted according to [CONTRIBUTING.md][0] + +### Affected core part(s) + +- [ ] buffer +- [ ] child_process +- [ ] cluster +- [ ] crypto +- [ ] dgram +- [ ] dns +- [ ] fs +- [ ] http +- [ ] https +- [ ] net +- [ ] tls +- [ ] tty +- [ ] vm +- [ ] zlib +- [ ] other _(please specify which)_ + +### SemVer + +What semver change does this change require? + +- [ ] patch _(no new APIs, no breaking changes)_ +- [ ] minor _(new APIs, no breaking changes)_ +- [ ] major _(breaking changes, or just too dangerous to be minor/patch)_ + +[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit From a96607bb4e625fb0e762cf354ac1d794e0493fed Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 15:53:17 -0500 Subject: [PATCH 02/23] github: improve --- .github/ISSUE_TEMPLATE.md | 8 ++++---- .github/PULL_REQUEST_TEMPLATE.md | 7 +++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 6ad7b4f5123a11..36fbd06eee472a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,11 +9,11 @@ reduced test case (without any external dependencies)_. ### Affected node.js versions -- [ ] v0.10 -- [ ] v0.12 -- [ ] v4.x -- [ ] v5.x - [ ] master +- [ ] v5.x +- [ ] v4.x +- [ ] v0.12 +- [ ] v0.10 ### Affected platforms diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e80c4998e3c5da..f0e85e4e95ed99 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -35,4 +35,11 @@ What semver change does this change require? - [ ] minor _(new APIs, no breaking changes)_ - [ ] major _(breaking changes, or just too dangerous to be minor/patch)_ +### LTS + +Should this patch be backported to: + +- [ ] current LTS +- [ ] older versions? _(please specify the version numbers)_ + [0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit From c24541862346709bb240e230434d1ac91c2fdb11 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 15:53:51 -0500 Subject: [PATCH 03/23] subsystem --- .github/ISSUE_TEMPLATE.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 36fbd06eee472a..c0b8020b301ba7 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -24,7 +24,7 @@ reduced test case (without any external dependencies)_. - [ ] solaris - [ ] other _(please specify which)_ -### Core part (if known) +### Core subsystem (if known) - [ ] buffer - [ ] child_process diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f0e85e4e95ed99..eeae4c6911bb8b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ _Please make sure to review and check all of these items_: - [ ] Does `make test` pass after this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] -### Affected core part(s) +### Affected core subsystem(s) - [ ] buffer - [ ] child_process From 260d590c3c8200bf39f6149eb58843c360ea6557 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:02:01 -0500 Subject: [PATCH 04/23] pr: doc/semver link --- .github/PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index eeae4c6911bb8b..058d704f480f31 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,6 +17,7 @@ _Please make sure to review and check all of these items_: - [ ] crypto - [ ] dgram - [ ] dns +- [ ] doc - [ ] fs - [ ] http - [ ] https @@ -29,7 +30,7 @@ _Please make sure to review and check all of these items_: ### SemVer -What semver change does this change require? +What [semver][1] change does this change require? - [ ] patch _(no new APIs, no breaking changes)_ - [ ] minor _(new APIs, no breaking changes)_ @@ -43,3 +44,4 @@ Should this patch be backported to: - [ ] older versions? _(please specify the version numbers)_ [0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit +[1]: http://semver.org/ From cc21cc036c7514f52832df71106f9163daf89bca Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:02:32 -0500 Subject: [PATCH 05/23] issue: doc subsystem --- .github/ISSUE_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index c0b8020b301ba7..427af2fd5b4b6d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -32,6 +32,7 @@ reduced test case (without any external dependencies)_. - [ ] crypto - [ ] dgram - [ ] dns +- [ ] doc - [ ] fs - [ ] http - [ ] https From 3b4f1f86ede2ada4c911bb1d09002ba407d99eca Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:33:44 -0500 Subject: [PATCH 06/23] fixes, remove LTS --- .github/ISSUE_TEMPLATE.md | 8 ++++---- .github/PULL_REQUEST_TEMPLATE.md | 9 +-------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 427af2fd5b4b6d..1d97ea1a8620d3 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -17,11 +17,11 @@ reduced test case (without any external dependencies)_. ### Affected platforms -- [ ] linux -- [ ] windows +- [ ] Linux +- [ ] Windows - [ ] OS X -- [ ] freebsd -- [ ] solaris +- [ ] FreeBSD +- [ ] Solaris - [ ] other _(please specify which)_ ### Core subsystem (if known) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 058d704f480f31..5363c590c018ed 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,7 +6,7 @@ _Please provide description of change here_. _Please make sure to review and check all of these items_: -- [ ] Does `make test` pass after this change? +- [ ] Does `make test` (or `vcbuild test nosign`) pass with this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] ### Affected core subsystem(s) @@ -36,12 +36,5 @@ What [semver][1] change does this change require? - [ ] minor _(new APIs, no breaking changes)_ - [ ] major _(breaking changes, or just too dangerous to be minor/patch)_ -### LTS - -Should this patch be backported to: - -- [ ] current LTS -- [ ] older versions? _(please specify the version numbers)_ - [0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit [1]: http://semver.org/ From cc4e4a1635c5323c161de886d1e772f8bf6bb19d Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:41:59 -0500 Subject: [PATCH 07/23] issue: fixes --- .github/ISSUE_TEMPLATE.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 1d97ea1a8620d3..485867ea33b387 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -7,13 +7,9 @@ _Please provide issue details here_. _Please provide necessary steps for reproduction of this issue, or better the reduced test case (without any external dependencies)_. -### Affected node.js versions +### Affected node.js version(s) -- [ ] master -- [ ] v5.x -- [ ] v4.x -- [ ] v0.12 -- [ ] v0.10 +_Please fill in affected version(s)_ ### Affected platforms From 56c64feab7dcc1e5b97d2a5c94dfd006b37f74c1 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:43:15 -0500 Subject: [PATCH 08/23] remove semver --- .github/PULL_REQUEST_TEMPLATE.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5363c590c018ed..2ec891c78a1c01 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -28,13 +28,4 @@ _Please make sure to review and check all of these items_: - [ ] zlib - [ ] other _(please specify which)_ -### SemVer - -What [semver][1] change does this change require? - -- [ ] patch _(no new APIs, no breaking changes)_ -- [ ] minor _(new APIs, no breaking changes)_ -- [ ] major _(breaking changes, or just too dangerous to be minor/patch)_ - [0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit -[1]: http://semver.org/ From 6ac44de124cdf57ad2eb81d8633e23de4bdeab4a Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:44:54 -0500 Subject: [PATCH 09/23] doc and tests --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2ec891c78a1c01..a4426608f8ba2a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,6 +8,10 @@ _Please make sure to review and check all of these items_: - [ ] Does `make test` (or `vcbuild test nosign`) pass with this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] +- [ ] Regression test (or benchmark if this is a performance-related change) is + included +- [ ] Documentation change or addition is included (if this change modifies + existing APIs, or introduces new ones) ### Affected core subsystem(s) From 498bd35df0cfccea49cfb86f8183987a41c93528 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Wed, 17 Feb 2016 16:47:36 -0500 Subject: [PATCH 10/23] possible dependencies --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 485867ea33b387..cc11fe08ea9ae2 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -5,7 +5,7 @@ _Please provide issue details here_. ### Steps to reproduce/test case _Please provide necessary steps for reproduction of this issue, or better the -reduced test case (without any external dependencies)_. +reduced test case (without any external dependencies, if possible)_. ### Affected node.js version(s) From ca81090207d02e9a9d718dabf7b63f8d057a9f64 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 14:11:48 -0500 Subject: [PATCH 11/23] update --- .github/ISSUE_TEMPLATE.md | 52 ++++++++------------------------ .github/PULL_REQUEST_TEMPLATE.md | 17 +---------- 2 files changed, 13 insertions(+), 56 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index cc11fe08ea9ae2..838c7ca0a462a1 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,40 +1,12 @@ -### Issue details - -_Please provide issue details here_. - -### Steps to reproduce/test case - -_Please provide necessary steps for reproduction of this issue, or better the -reduced test case (without any external dependencies, if possible)_. - -### Affected node.js version(s) - -_Please fill in affected version(s)_ - -### Affected platforms - -- [ ] Linux -- [ ] Windows -- [ ] OS X -- [ ] FreeBSD -- [ ] Solaris -- [ ] other _(please specify which)_ - -### Core subsystem (if known) - -- [ ] buffer -- [ ] child_process -- [ ] cluster -- [ ] crypto -- [ ] dgram -- [ ] dns -- [ ] doc -- [ ] fs -- [ ] http -- [ ] https -- [ ] net -- [ ] tls -- [ ] tty -- [ ] vm -- [ ] zlib -- [ ] other _(please specify which)_ +_Thanks for wanting to report an issue you've found in node.js. Please fill in +below template. If unsure about something, just do as best as you're able._ + +_Note that it will be much easier for us to fix the issue if we will have a test +case that reproduces the problem. Ideally this test case should not have any +external dependencies. We understand that it is not always possible to reduce +your code to a small test case, but we will appreciate to have as much data as +possible. Thank you!_ + +**Version**: _enter affected node.js version(s)_ +**Platform**: _either `uname -a` output or Windows version and cpu-bitsize_ +**Subsystem**: _optional. if known - please specify affected core module name_ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a4426608f8ba2a..c99a49fd702841 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,21 +15,6 @@ _Please make sure to review and check all of these items_: ### Affected core subsystem(s) -- [ ] buffer -- [ ] child_process -- [ ] cluster -- [ ] crypto -- [ ] dgram -- [ ] dns -- [ ] doc -- [ ] fs -- [ ] http -- [ ] https -- [ ] net -- [ ] tls -- [ ] tty -- [ ] vm -- [ ] zlib -- [ ] other _(please specify which)_ +_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_ [0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit From eea3f1b4e0ba0837b936c17f0f0d320fef7f5a9b Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 14:13:30 -0500 Subject: [PATCH 12/23] issue_template: formatting --- .github/ISSUE_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 838c7ca0a462a1..6124ffa9c37995 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -8,5 +8,8 @@ your code to a small test case, but we will appreciate to have as much data as possible. Thank you!_ **Version**: _enter affected node.js version(s)_ + **Platform**: _either `uname -a` output or Windows version and cpu-bitsize_ + **Subsystem**: _optional. if known - please specify affected core module name_ + From b3b6fa690132bb97267e0246ba5ae47488a2f2a7 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 14:14:01 -0500 Subject: [PATCH 13/23] format --- .github/ISSUE_TEMPLATE.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 6124ffa9c37995..081c184d016334 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -7,9 +7,6 @@ external dependencies. We understand that it is not always possible to reduce your code to a small test case, but we will appreciate to have as much data as possible. Thank you!_ -**Version**: _enter affected node.js version(s)_ - -**Platform**: _either `uname -a` output or Windows version and cpu-bitsize_ - -**Subsystem**: _optional. if known - please specify affected core module name_ - +* **Version**: _enter affected node.js version(s)_ +* **Platform**: _either `uname -a` output or Windows version and cpu-bitsize_ +* **Subsystem**: _optional. if known - please specify affected core module name_ From 03ffbae88863f60f4256338dd7964dbdbcbe6d99 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 14:53:19 -0500 Subject: [PATCH 14/23] issue: fix --- .github/ISSUE_TEMPLATE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 081c184d016334..d045621c46c588 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,5 +1,6 @@ -_Thanks for wanting to report an issue you've found in node.js. Please fill in -below template. If unsure about something, just do as best as you're able._ +_Thanks for wanting to report an issue you've found in node.js. Please delete +this text and fill in below template. If unsure about something, just do as best +as you're able._ _Note that it will be much easier for us to fix the issue if we will have a test case that reproduces the problem. Ideally this test case should not have any From 68d8e47b7a2fb428361d04117e97a06e679cc022 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 15:15:32 -0500 Subject: [PATCH 15/23] fix --- .github/ISSUE_TEMPLATE.md | 3 ++- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d045621c46c588..c3b5232d1000a9 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,5 +9,6 @@ your code to a small test case, but we will appreciate to have as much data as possible. Thank you!_ * **Version**: _enter affected node.js version(s)_ -* **Platform**: _either `uname -a` output or Windows version and cpu-bitsize_ +* **Platform**: _either `uname -a` output, or if Windows version and 32-bit or + 64-bit_ * **Subsystem**: _optional. if known - please specify affected core module name_ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c99a49fd702841..bdd42622979fdc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ _Please make sure to review and check all of these items_: - [ ] Does `make test` (or `vcbuild test nosign`) pass with this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] - [ ] Regression test (or benchmark if this is a performance-related change) is - included + included (only required for code changes) - [ ] Documentation change or addition is included (if this change modifies existing APIs, or introduces new ones) From 06d9c1bfa02e079150ca2c912fd1e04e4bc4b919 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 16:02:39 -0500 Subject: [PATCH 16/23] fix --- .github/ISSUE_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index c3b5232d1000a9..61e27646e8dd7d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,4 @@ -_Thanks for wanting to report an issue you've found in node.js. Please delete +_Thanks for wanting to report an issue you've found in Node.js. Please delete this text and fill in below template. If unsure about something, just do as best as you're able._ @@ -8,7 +8,7 @@ external dependencies. We understand that it is not always possible to reduce your code to a small test case, but we will appreciate to have as much data as possible. Thank you!_ -* **Version**: _enter affected node.js version(s)_ +* **Version**: _enter affected Node.js version(s)_ * **Platform**: _either `uname -a` output, or if Windows version and 32-bit or 64-bit_ * **Subsystem**: _optional. if known - please specify affected core module name_ From 494e9181fada73732932e201db1fdc4a1e10fe05 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 16:12:16 -0500 Subject: [PATCH 17/23] fix --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bdd42622979fdc..5ded8b3d4209dd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,10 @@ ### Description of change -_Please provide description of change here_. +_Please provide description of change here._ ### Pull Request check-list -_Please make sure to review and check all of these items_: +_Please make sure to review and check all of these items:_ - [ ] Does `make test` (or `vcbuild test nosign`) pass with this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] From 0f813016d9d12579555cb2128c979e67416ed8a2 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 16:13:00 -0500 Subject: [PATCH 18/23] ack --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5ded8b3d4209dd..c74ce26f827b2d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,7 +6,7 @@ _Please provide description of change here._ _Please make sure to review and check all of these items:_ -- [ ] Does `make test` (or `vcbuild test nosign`) pass with this change? +- [ ] Does `make -j8 test` (or `vcbuild test nosign`) pass with this change? - [ ] Is commit message formatted according to [CONTRIBUTING.md][0] - [ ] Regression test (or benchmark if this is a performance-related change) is included (only required for code changes) From d7ca0a5f52ff336fdd63b734bec08ad7e9c78ee2 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Fri, 19 Feb 2016 16:42:53 -0500 Subject: [PATCH 19/23] win --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 61e27646e8dd7d..7cbecfa76ad97d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,6 +9,6 @@ your code to a small test case, but we will appreciate to have as much data as possible. Thank you!_ * **Version**: _enter affected Node.js version(s)_ -* **Platform**: _either `uname -a` output, or if Windows version and 32-bit or +* **Platform**: _either `uname -a` output, or if Windows, version and 32-bit or 64-bit_ * **Subsystem**: _optional. if known - please specify affected core module name_ From 93be8da9d417e145c026daec919600b61c859f1b Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Mon, 22 Feb 2016 15:30:55 -0500 Subject: [PATCH 20/23] github: fix nits --- .github/ISSUE_TEMPLATE.md | 10 +++++----- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++--- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 7cbecfa76ad97d..8d81a93d5ca21a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,11 +1,11 @@ _Thanks for wanting to report an issue you've found in Node.js. Please delete -this text and fill in below template. If unsure about something, just do as best -as you're able._ +this text and fill in the template below. If unsure about something, just do as +best as you're able._ -_Note that it will be much easier for us to fix the issue if we will have a test -case that reproduces the problem. Ideally this test case should not have any +_Note that it will be much easier for us to fix the issue if a test case that +reproduces the problem is provided. Ideally this test case should not have any external dependencies. We understand that it is not always possible to reduce -your code to a small test case, but we will appreciate to have as much data as +your code to a small test case, but we would appreciate to have as much data as possible. Thank you!_ * **Version**: _enter affected Node.js version(s)_ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c74ce26f827b2d..c25f9038466d8f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,18 +1,22 @@ ### Description of change -_Please provide description of change here._ +_Please provide a description of change here._ ### Pull Request check-list _Please make sure to review and check all of these items:_ -- [ ] Does `make -j8 test` (or `vcbuild test nosign`) pass with this change? -- [ ] Is commit message formatted according to [CONTRIBUTING.md][0] +- [ ] Does `make -j8 test` (or `vcbuild test nosign`) pass with this change + (including linting)? +- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0] - [ ] Regression test (or benchmark if this is a performance-related change) is included (only required for code changes) - [ ] Documentation change or addition is included (if this change modifies existing APIs, or introduces new ones) +_NOTE: these things are not required to open a PR and can be done afterwards / +while the PR is open._ + ### Affected core subsystem(s) _Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_ From d032d94219b19c1631a6cd4240462cdc79e36152 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Mon, 22 Feb 2016 19:00:59 -0500 Subject: [PATCH 21/23] github: fixes --- .github/ISSUE_TEMPLATE.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 8d81a93d5ca21a..0d10c2a8417c1c 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -8,7 +8,7 @@ external dependencies. We understand that it is not always possible to reduce your code to a small test case, but we would appreciate to have as much data as possible. Thank you!_ -* **Version**: _enter affected Node.js version(s)_ +* **Version**: _output of `node -v`_ * **Platform**: _either `uname -a` output, or if Windows, version and 32-bit or 64-bit_ * **Subsystem**: _optional. if known - please specify affected core module name_ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c25f9038466d8f..74b0bdbbadb89e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,13 +6,13 @@ _Please provide a description of change here._ _Please make sure to review and check all of these items:_ -- [ ] Does `make -j8 test` (or `vcbuild test nosign`) pass with this change - (including linting)? +- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with + this change (including linting)? - [ ] Is the commit message formatted according to [CONTRIBUTING.md][0] -- [ ] Regression test (or benchmark if this is a performance-related change) is - included (only required for code changes) -- [ ] Documentation change or addition is included (if this change modifies - existing APIs, or introduces new ones) +- [ ] Is a regression test (or benchmark if this is a performance-related + change) is included (only required for code changes)? +- [ ] Is a documentation change or addition included (if this change modifies + existing APIs, or introduces new ones)? _NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open._ From ab479c5029cdd5c3ea6019da8210a8086859e693 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Mon, 22 Feb 2016 21:39:16 -0500 Subject: [PATCH 22/23] github: fix nits --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 74b0bdbbadb89e..0b9398a0c4e7dc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,6 @@ ### Description of change -_Please provide a description of change here._ +_Please provide a description of the change here._ ### Pull Request check-list @@ -8,10 +8,10 @@ _Please make sure to review and check all of these items:_ - [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with this change (including linting)? -- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0] -- [ ] Is a regression test (or benchmark if this is a performance-related - change) is included (only required for code changes)? -- [ ] Is a documentation change or addition included (if this change modifies +- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]? +- [ ] If this change fixes a bug (or a performance problem), is a regression + test included (or a benchmark)? +- [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? _NOTE: these things are not required to open a PR and can be done afterwards / From 3ba6e1106091b64017de990a967d3d9e94415d81 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Mon, 22 Feb 2016 22:49:23 -0500 Subject: [PATCH 23/23] github: last nit --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0b9398a0c4e7dc..212ea943c87ae2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ _Please make sure to review and check all of these items:_ this change (including linting)? - [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]? - [ ] If this change fixes a bug (or a performance problem), is a regression - test included (or a benchmark)? + test (or a benchmark) included? - [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?